Attachment 3935 Details for Bug 24141

[patch] Behebt angesprochene Mängel

univention-updater-2011-12-02-01.patch (text/plain), 1.49 KB, created by Frank Greif on 2011-12-02 12:23 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Greif

Created: 2011-12-02 12:23 CET

Size: 1.49 KB

patch

obsolete

>Index: umc/js/_updater/DetailsPage.js
>===================================================================
>--- umc/js/_updater/DetailsPage.js	(revision 5406)
>+++ umc/js/_updater/DetailsPage.js	(working copy)
>@@ -89,7 +89,7 @@
> 	    	{
> 	    		type:			'TextBox',
> 	    		name:			'name',
>-	    		label:			this._("Component Name")
>+	    		label:			this._("Component Name"),
> 	    	},
> 	    	{
> 	    		type:			'TextBox',
>@@ -159,17 +159,20 @@
>     	this._form = new umc.modules._updater.Form({
>     		widgets:		widgets,
>     		layout:			layout,
>+    		scrollable:		true,
>     		//buttons:		buttons,
>-    		moduleStore:	umc.store.getModuleStore('name','updater/components'),
>-    		// This is (a) the submit handler of the form, but
>-    		// also (b) the onClick handler of the 'Apply' button
>-    		onSubmit: dojo.hitch(this,function() {
>-    	    	this._form.standby(true);
>-    	        this._form.save(this._save_options);
>-    		})	
>+    		moduleStore:	umc.store.getModuleStore('name','updater/components')
>     	});
>     	this.addChild(this._form);
>     	
>+    	// A tip from Alexander: the onSubmit event of our base class
>+    	// should remain intact in all cases: instead of overwriting that event we should
>+    	// better connect to it.
>+    	dojo.connect(this._form,'onSubmit',dojo.hitch(this,function() {
>+	    	this.standby(true);
>+	        this._form.save(this._save_options);
>+		}));
>+    	
>     	dojo.connect(this._form,'onSaved',dojo.hitch(this, function(success,data) {
>     		this.standby(false);
>     		try

Actions: View | Diff

Attachments on bug 24141: 3751 | 3752 | 3935