Univention Bugzilla – Attachment 8242 Details for
Bug 43051
italc 3.0 segfault in screenshot()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
43051.patch (text/plain), 1.50 KB, created by
Florian Best
on 2016-11-25 12:30 CET
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Florian Best
Created:
2016-11-25 12:30 CET
Size:
1.50 KB
patch
obsolete
>diff --git a/italc/italc/lib/src/ItalcVncConnection.cpp b/italc/italc/lib/src/ItalcVncConnection.cpp >index 4fd55be..347a269 100644 >--- a/italc/italc/lib/src/ItalcVncConnection.cpp >+++ b/italc/italc/lib/src/ItalcVncConnection.cpp >@@ -116,22 +116,24 @@ rfbBool ItalcVncConnection::hookNewClient( rfbClient *cl ) > > const int size = (int) cl->width * cl->height * > ( cl->format.bitsPerPixel / 8 ); >- if( t->m_frameBuffer ) >- { >- // do not leak if we get a new framebuffer size >- delete [] t->m_frameBuffer; >- } >- t->m_frameBuffer = new uint8_t[size]; >- t->m_framebufferInitialized = false; >- cl->frameBuffer = t->m_frameBuffer; >- memset( cl->frameBuffer, '\0', size ); >- cl->format.bitsPerPixel = 32; >- cl->format.redShift = 16; >- cl->format.greenShift = 8; >- cl->format.blueShift = 0; >- cl->format.redMax = 0xff; >- cl->format.greenMax = 0xff; >- cl->format.blueMax = 0xff; >+ if (t->m_image.width() != cl->width && t->m_image.height() != cl->height) { >+ if( t->m_frameBuffer ) >+ { >+ // do not leak if we get a new framebuffer size >+ delete [] t->m_frameBuffer; >+ } >+ t->m_frameBuffer = new uint8_t[size]; >+ t->m_framebufferInitialized = false; >+ cl->frameBuffer = t->m_frameBuffer; >+ memset( cl->frameBuffer, '\0', size ); >+ cl->format.bitsPerPixel = 32; >+ cl->format.redShift = 16; >+ cl->format.greenShift = 8; >+ cl->format.blueShift = 0; >+ cl->format.redMax = 0xff; >+ cl->format.greenMax = 0xff; >+ cl->format.blueMax = 0xff; >+ } > > // only use remote cursor for remote control > cl->appData.useRemoteCursor = false;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
Actions:
View
|
Diff
Attachments on
bug 43051
:
8242
|
8254