Bug 26418 - Überarbeitung der Ergebnisliste und der Buttons
Überarbeitung der Ergebnisliste und der Buttons
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 3.0
Other Linux
: P1 enhancement (vote)
: UCS 3.2
Assigned To: Florian Best
Alexander Kläser
: interim-3
: 27094 30519 32314 32672 32674 32675 32777 (view as bug list)
Depends on:
Blocks: 32751 33180 33187 33188
  Show dependency treegraph
 
Reported: 2012-03-09 10:07 CET by Alexander Kläser
Modified: 2013-11-19 06:42 CET (History)
6 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Design, Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2012-03-09 10:07:21 CET
Generell werden Aktionen unterhalb des Grids angezeigt (in unserem bisherigen Bedienkonzept). Dies scheint nicht günstig zu sein, da die Aktionen nicht unmittelbar gefunden werden. Idealerweise würden die Aktions-Buttons über dem Grid angezeigt werden, damit sie direkt gefunden werden können (es handelt sich ja um Hauptaktion wie "Benutzer hinzufügen").

Die "normalen" Buttons (nur unterstrichener Text) werden insbesondere in Dialogen, in denen sie zusammen mit einem Default-Button (in grün) auftauchen nicht unmittelbar erkannt. Das hängt auch mit den Aktions-Buttons unter dem Grids zusammen, die ggf. auch wegen ihres eher zurückhaltenden Design nicht gefunden werden.

Ziel ist es, diese Punkte und Bedienkonzepte so zu überarbeiten, dass sie intuitiv direkt von den Benutzern verstanden werden.
Comment 1 Alexander Kläser univentionstaff 2012-03-09 11:23:16 CET
Ein anderer Hinweis:

In der Übersicht und auch anderswo wird teilweise vermutet, dass durch Scrollen noch weitere Funktionen weiter unten zu finden sind. Es ist nicht direkt ersichtlich, dass noch etwas weiter kommt, da durch den abschliessenden Strich die Seite abgeschlossen aussieht.
Comment 2 Alexander Kläser univentionstaff 2012-03-09 11:24:59 CET
(In reply to comment #1)
> Ein anderer Hinweis:
> 
> In der Übersicht und auch anderswo wird teilweise vermutet, dass durch Scrollen
> noch weitere Funktionen weiter unten zu finden sind. Es ist nicht direkt
> ersichtlich, dass noch etwas weiter kommt, da durch den abschliessenden Strich
> die Seite abgeschlossen aussieht.

Anscheinend wirkt die abschliessende Linie stärker als der Scrollbalken. Der Scrollbalken scheint eher technisch zu sein, der insbesondere dann verstanden wird, wenn er sich ganz am Rand des Fensters befindet. Die Liste ist ja quasi ein Fenster in einem Fenster. Die Linie hingegen ist was festes.
Comment 3 Alexander Kläser univentionstaff 2012-05-15 11:12:23 CEST
*** Bug 27094 has been marked as a duplicate of this bug. ***
Comment 4 Alexander Kläser univentionstaff 2013-07-19 18:24:12 CEST
*** Bug 28073 has been marked as a duplicate of this bug. ***
Comment 5 Florian Best univentionstaff 2013-09-17 08:42:17 CEST
*** Bug 32314 has been marked as a duplicate of this bug. ***
Comment 6 Alexander Kläser univentionstaff 2013-09-24 15:09:22 CEST
The text entries in the first column were not underlined in my tests.
Comment 7 Alexander Kläser univentionstaff 2013-09-24 17:54:55 CEST
*** Bug 32672 has been marked as a duplicate of this bug. ***
Comment 8 Alexander Kläser univentionstaff 2013-09-24 17:55:26 CEST
(In reply to Alexander Kläser from comment #7)
> *** Bug 32672 has been marked as a duplicate of this bug. ***

From Bug 32672:
> I use Firefox (24.0) and Chromium (28.0.1500.71-0ubuntu1.12.04.1).
> 
> If i click on a single item in a grid in any module (e.g. a user in the
> users module), the behaviour differs: 
> 
> Firefox: The item is opened for editing. 
> Chromium: The item's checkbox gets ticket and nothing else happens.
> 
> Expected behaviour: The item is opened for editing (as it is with UCS 3.1)
Comment 9 Alexander Kläser univentionstaff 2013-09-24 18:06:23 CEST
*** Bug 32674 has been marked as a duplicate of this bug. ***
Comment 10 Alexander Kläser univentionstaff 2013-09-24 18:06:54 CEST
The cell (In reply to Alexander Kläser from comment #9)
> *** Bug 32674 has been marked as a duplicate of this bug. ***

From Bug 32674:
> The first context menu item in many modules (users, computers, groups, ...)
> is empty but selectable. If i click it nothing happens. This looks like an
> error, as if a text had not been loaded or an error occured. 
> 
> This first empty item should not be displayed.
Comment 11 Alexander Kläser univentionstaff 2013-09-30 10:48:46 CEST
*** Bug 32675 has been marked as a duplicate of this bug. ***
Comment 12 Alexander Kläser univentionstaff 2013-09-30 10:57:04 CEST
From Bug 32675:
> I would prefer all action on the left top corner ...
> 
> add new - edit - start - ...
> 
> item1
> itme2
> item3

This will be adjusted as suggested, i.e., non-context actions go to the very left.

Actions in the "toolbar" will also be shortened, e.g., "Add new user" → "New".

When no items are selected, the context buttons will disappear.

The first column will be underlined on mouseover (we could also change the color to green, similar to links?).

Additional information about how many elements are selected (other than in the status bar) will be removed.
Comment 13 Alexander Kläser univentionstaff 2013-09-30 18:07:25 CEST
For backwards compatibility, we need a new flag that allows to display an action additionally also in the row (e.g., for UVMM and computer room module in UCS@school).
Comment 14 Dirk Wiesenthal univentionstaff 2013-10-01 17:08:15 CEST
Disabled actions have a greyed out icon. But as some actions do not have any icon and the text is not greyed out in any case, it is hard (read: impossible) to say whether an action is clickable or not.

Example: "Execute" in join module
Comment 15 Alexander Kläser univentionstaff 2013-10-02 09:33:11 CEST
(In reply to Dirk Wiesenthal from comment #14)
> Disabled actions have a greyed out icon. But as some actions do not have any
> icon and the text is not greyed out in any case, it is hard (read:
> impossible) to say whether an action is clickable or not.
> 
> Example: "Execute" in join module

This will be done via Bug 32218, comment 4.
Comment 16 Florian Best univentionstaff 2013-10-08 14:16:16 CEST
The following adaption also have been done:

uvmm/SnapshotGrid.js → OK
uvmm/InterfaceGrid.js → OK
uvmm/DriveGrid.js → "Medium wechseln" as standard action
uvmm.js → "Erstellen einer VM" → "Erstellen"
pkgdb/Page.js → OK
quota.js → OK
ucr.js → OK
join/Grid.js → "Force Execute" as standard action
quota/PartitionPage.js → "Add user" → "Add"
udm.js → "Objekt hinzufügen" → "Add"
setup/InterfaceGrid.js → "Add Interface" → "Add"
top.js → "Terminate", "Force Terminate" as standard action
printers/OverviewPage.js → "view details", "activate", "deactivate" as standard action
printers/DetailPage.js → OK
printers/QuotaPage.js → "clear", "edit" as standard action
appcenter/SettingsPage.js → "On/Off" → "Enable", "Disable"
appcenter/PackagesPage.js → "show details", "install", "uninstall", "upgrade" as standard action
services.js → "{Start,Stop} services" → "{Start, Stop}" also as standard action
Comment 17 Florian Best univentionstaff 2013-10-09 11:33:34 CEST
*** Bug 32777 has been marked as a duplicate of this bug. ***
Comment 18 Florian Best univentionstaff 2013-10-09 11:48:14 CEST
*** Bug 30519 has been marked as a duplicate of this bug. ***
Comment 19 Florian Best univentionstaff 2013-10-10 14:28:30 CEST
all points adressed in univention-management-console-frontend (3.0.98-1)
Comment 20 Alexander Kläser univentionstaff 2013-10-11 12:46:18 CEST
Two little points:
(a) When clicking on the cell of the first column (not the text), nothing happens → the row should be selected/deselected.
(b) When clicking on the text of the first column, the object is opened + the cell's selection is toggled → the selection should stay
Comment 21 Florian Best univentionstaff 2013-10-11 13:14:46 CEST
(In reply to Alexander Kläser from comment #20)
> Two little points:
> (a) When clicking on the cell of the first column (not the text), nothing
> happens → the row should be selected/deselected.
> (b) When clicking on the text of the first column, the object is opened +
> the cell's selection is toggled → the selection should stay

oups, this was just a missing "else".
univention-management-console-frontend (3.0.103-1) 
* Bug #26418: fix grid selection when clicking on row
Comment 22 Florian Best univentionstaff 2013-10-15 14:55:50 CEST
A workaround in the udm module has also been removed. The default action in the LDAP-Navigation for containers is now more stable. svn45086
Comment 23 Alexander Kläser univentionstaff 2013-10-16 16:44:49 CEST
The tooltips in UVMM disappeared. Maybe due to adaptations from this bug?
Comment 24 Florian Best univentionstaff 2013-10-18 14:07:23 CEST
(In reply to Alexander Kläser from comment #23)
> The tooltips in UVMM disappeared. Maybe due to adaptations from this bug?
No, they are working. Probably disabled tooltip settings.
Comment 25 Dirk Wiesenthal univentionstaff 2013-10-23 09:55:58 CEST
dijit.registry.toArray().length reveils massive memory leaks in current Grid implementation. Former grid had an ugly but necessary _univention_cache hack.

Just open UCR module, scroll a bit and close it again
Comment 26 Dirk Wiesenthal univentionstaff 2013-10-23 16:48:25 CEST
This "0 entries of 2 selected" has no padding-left anymore. Looks squeezed.
Comment 27 Dirk Wiesenthal univentionstaff 2013-10-24 10:28:14 CEST
I do not know whether this is an issue introduced via this fix, but clicking that "Select all" checkbox in the grid header when having a lot of items in that grid (e.g. UCR) takes ages. Even items.length < 1000 makes Firefox ask me whether I want to quit.

If this is not due to this bug's changes, please open a new bug. This is not acceptable.
Comment 28 Alexander Kläser univentionstaff 2013-10-24 12:23:44 CEST
As discussed: clicking an a row should clear the selection and only select the row item.
Comment 29 Florian Best univentionstaff 2013-10-24 14:14:13 CEST
(In reply to Dirk Wiesenthal from comment #25)
> dijit.registry.toArray().length reveils massive memory leaks in current Grid
> implementation. Former grid had an ugly but necessary _univention_cache hack.
> 
> Just open UCR module, scroll a bit and close it again
fixed memory leaks, also fixed one error in the UCR module directly.

(In reply to Dirk Wiesenthal from comment #26)
> This "0 entries of 2 selected" has no padding-left anymore. Looks squeezed.
Added again.

(In reply to Alexander Kläser from comment #28)
> As discussed: clicking an a row should clear the selection and only select
> the row item.
Ok

(In reply to Dirk Wiesenthal from comment #27)
> I do not know whether this is an issue introduced via this fix, but clicking
> that "Select all" checkbox in the grid header when having a lot of items in
> that grid (e.g. UCR) takes ages. Even items.length < 1000 makes Firefox ask
> me whether I want to quit.
> 
> If this is not due to this bug's changes, please open a new bug. This is not
> acceptable.
I fixed this by adding a timeout of 50ms before updating the header and footer. On IE8 a pop up occurs when selecting 1000 items. → Bug #32977
Comment 30 Alexander Kläser univentionstaff 2013-11-04 18:11:54 CET
Changelog: OK, has been adapted
Comment 31 Alexander Kläser univentionstaff 2013-11-04 18:18:36 CET
Empty grid crashes when selecting all entries → Bug 33107
Comment 32 Alexander Kläser univentionstaff 2013-11-05 11:13:48 CET
I tested different browsers (mobile + desktop) in different UMC modules. Everything seems fine so far. All the mentioned points have been addressed (incl. clean up, fast select all, selection on row click etc.).

I really like the revised grid, nice work :) !
Comment 33 Stefan Gohmann univentionstaff 2013-11-19 06:42:37 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".