Bug 30806 - Interface-edit does not read model: always defaults to RealTek
Interface-edit does not read model: always defaults to RealTek
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Virtual machines (UVMM)
UCS 3.1
Other Linux
: P4 normal (vote)
: UCS 3.2
Assigned To: Philipp Hahn
Florian Best
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-18 11:15 CET by Philipp Hahn
Modified: 2013-11-19 06:43 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Troubleshooting, Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-03-18 11:15:39 CET
UMC → UVMM → VM edit → Devices → Interfaces → Edit

When an interface is modified, the current model (e1000, realtek, virtio) is not put into the combo box, but always defaults to using the "default (RealTek RTL-8139)" selection.

u-v-m-m/umc/js/uvmm/InterfaceWizard.js:113#_setInitialValues() seems to no longer do the right thing.
Comment 1 Philipp Hahn univentionstaff 2013-07-25 20:13:36 CEST
Fixed.
Also Changed the example MAC-address from 01:23:45:67:89:ab to 02:...., since every MAC-address with the LSB in the first octet set is a *multicast* address, which is rejected by libvirt:
> error: XML error: expected unicast mac address, found multicast '01:00:00:00:00:00'

svn2785,42786
univention-virtual-machine-manager-daemon_3.0.6-1.458.201307252006

ChangeLog: The dialog for editing network interfaces now correctly starts with the currrent values. Multicast MAC addresses are now detected and rejected
Comment 2 Florian Best univentionstaff 2013-07-26 09:59:50 CEST
The change causes that the title of the InterfaceDialog/form is "Edit network interface" when "Adding" an interface.

FYI: in JavaScript an empty object ({}) evaluates as Boolean({}) === true.
Comment 3 Florian Best univentionstaff 2013-07-26 10:04:35 CEST
The selection of the interface model works.

Changelog OK

If a user enters a multicast MAC address he only gets the hint that the MAC address is invalid with an example of the form. If the syntax of the MAC address is correct the user wonders why the MAC address is rejected. A hint about this would be great.
Comment 4 Philipp Hahn univentionstaff 2013-07-26 12:32:18 CEST
(In reply to Florian Best from comment #2)
> The change causes that the title of the InterfaceDialog/form is "Edit
> network interface" when "Adding" an interface.

svn42806: use values.$id$.


(In reply to Florian Best from comment #3)
> If a user enters a multicast MAC address he only gets the hint that the MAC
> address is invalid with an example of the form. If the syntax of the MAC
> address is correct the user wonders why the MAC address is rejected. A hint
> about this would be great.

msgid ""
"Invalid MAC address: The address must be unicast and should have the form "
"\"02:23:45:67:89:AB\"."
msgstr ""
"Ungültige MAC-Adresse: Die Adresse muß unicast sein und soll die Form "
"\"02:23:45:67:89:AB\" haben."

univention-virtual-machine-manager-daemon_3.0.6-2.459.201307261228
Comment 5 Florian Best univentionstaff 2013-07-26 13:06:42 CEST
typo: s/muß/muss/
Comment 6 Philipp Hahn univentionstaff 2013-07-26 14:13:35 CEST
(In reply to Florian Best from comment #5)
> typo: s/muß/muss/

svn42816
univention-virtual-machine-manager-daemon_3.0.6-4.461.201307261408
Comment 7 Florian Best univentionstaff 2013-07-26 14:35:41 CEST
OK
Comment 8 Stefan Gohmann univentionstaff 2013-11-19 06:43:48 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".