Bug 32611 - Replace deprecated UCS start site templates for links with UCR variables
Replace deprecated UCS start site templates for links with UCR variables
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 3.1
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Felix Botner
Erik Damrose
: interim-3
Depends on: 31805
Blocks: 32761 32762
  Show dependency treegraph
 
Reported: 2013-09-17 02:56 CEST by Alexander Kläser
Modified: 2013-11-19 06:44 CET (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Logo for univention doc (28.51 KB, image/svg+xml)
2013-10-01 11:04 CEST, Alexander Kläser
Details
Univention doc logo with slight adaptations. (31.02 KB, image/svg+xml)
2013-10-01 11:30 CEST, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2013-09-17 02:56:02 CEST
Via Bug 31805, the template mechanism for links on the UCS start site has been replaced with UCR variables. A few packages need to be adapted (e.g., nagios).
Comment 1 Alexander Kläser univentionstaff 2013-09-18 11:14:11 CEST
After the adjustments, all references to /var/www/ucs-overview/en.html and de.html will be removed such that the files will either be deleted automatically by UCR or need to be deleted manually in the postinst script.
Comment 2 Dirk Wiesenthal univentionstaff 2013-09-18 12:00:35 CEST
(In reply to Alexander Kläser from comment #0)
> A few packages need to be adapted (e.g.,
> nagios).

And univention-management-console-doc
Comment 3 Alexander Kläser univentionstaff 2013-09-19 14:38:54 CEST
And the package univention-demo-configuration.
Comment 4 Moritz Muehlenhoff univentionstaff 2013-09-19 14:39:41 CEST
The configuration wizard of the AD connectors needs to be ported as well.
Comment 5 Alexander Kläser univentionstaff 2013-09-19 16:28:53 CEST
(In reply to Moritz Muehlenhoff from comment #4)
> The configuration wizard of the AD connectors needs to be ported as well.

In which package is the entry for the UCS start site? I could not find any template in the package univention-ad-connector.
Comment 6 Moritz Muehlenhoff univentionstaff 2013-09-20 07:28:29 CEST
(In reply to Alexander Kläser from comment #5)
> (In reply to Moritz Muehlenhoff from comment #4)
> > The configuration wizard of the AD connectors needs to be ported as well.
> 
> In which package is the entry for the UCS start site? I could not find any
> template in the package univention-ad-connector.

That was an error on my side; I just checked on 3.1 and it's not linked from the start page, but instead through a UMC system module.
Comment 7 Felix Botner univentionstaff 2013-09-30 14:58:36 CEST
* univention-nagios - removed templates, added new ucs vars

* univention-system-setup - 
    setup-join.sh - replaced commit of ucs-overview templates with commit of
                  new templates
    scripts/20_language/11default_locale - do not set apache2/startsite

* univention-doc - removed templates, added new ucs vars

* univention-demo-configuration - removed templates, added new ucs vars
Comment 8 Stefan Gohmann univentionstaff 2013-10-01 06:37:39 CEST
Please move the Nagios link to the administration tab.
Comment 9 Alexander Kläser univentionstaff 2013-10-01 10:44:57 CEST
univention-doc has now an entry in the services tab and points to /univention-doc which is in the old layout. I would suggest to remove the HTML files in univention-doc completely (index.html is a UCR template). Instead it would make sense that the corresponding packages that are being shown below univention-doc (i.e., univention-doc itself, univention-management-console, univention-management-console-frontend) register themselves via UCR variables on the administration tab of the overview site. A separate icon for Univention documentation would be nice.
Comment 10 Alexander Kläser univentionstaff 2013-10-01 11:04:35 CEST
Created attachment 5480 [details]
Logo for univention doc

Suggestion for a possible logo.
Comment 11 Alexander Kläser univentionstaff 2013-10-01 11:30:08 CEST
Created attachment 5482 [details]
Univention doc logo with slight adaptations.
Comment 12 Dirk Wiesenthal univentionstaff 2013-10-01 11:42:01 CEST
(In reply to Stefan Gohmann from comment #8)
> Please move the Nagios link to the administration tab.

It should be possible to let the App Center handle that. See Bug#32609
Comment 13 Alexander Kläser univentionstaff 2013-10-01 13:24:54 CEST
(In reply to Dirk Wiesenthal from comment #12)
> (In reply to Stefan Gohmann from comment #8)
> > Please move the Nagios link to the administration tab.
> 
> It should be possible to let the App Center handle that. See Bug#32609

IMHO, it would be better to let the system package do that. In that way, the link will also be shown if one installs nagios via the CLI.
Comment 14 Dirk Wiesenthal univentionstaff 2013-10-01 16:15:16 CEST
(In reply to Alexander Kläser from comment #13)
> (In reply to Dirk Wiesenthal from comment #12)
> > (In reply to Stefan Gohmann from comment #8)
> > > Please move the Nagios link to the administration tab.
> > 
> > It should be possible to let the App Center handle that. See Bug#32609
> 
> IMHO, it would be better to let the system package do that. In that way, the
> link will also be shown if one installs nagios via the CLI.

If one installs nagios no UCR variable is added. One has to intentionally install univention-nagios which I think will not happen too often, because apparently, one wants the UCS integration, but one refuses to use the tools.

If someone installs univention-nagios without the App Center, no LDAP object in cn=apps,cn=univention,$ldap_base will be added either. So this installation is broken in terms of "full integration" even without the UCR issues.

If one does it in the ini file, there is only one place to store the description. And it is easier to change them. So I would use the App Center.

Anyway, this is how to do it:

If you want to add the UCR variables in postinst:
WebInterface=/nagios
UCSOverviewCategory=False

If you want to use the App Center:
WebInterface=/nagios
UCSOverviewCategory=admin
Comment 15 Alexander Kläser univentionstaff 2013-10-01 16:25:00 CEST
(In reply to Dirk Wiesenthal from comment #14)
> ...
> If someone installs univention-nagios without the App Center, no LDAP object
> in cn=apps,cn=univention,$ldap_base will be added either. So this
> installation is broken in terms of "full integration" even without the UCR
> issues.

It is not really "broken" since in terms of functionality for the user everything works as expected (or am I missing something?). Yes, technically speaking, the integration is not complete. But that is not really necessary is nagios is a system component that does not make use of any app center features. 
However, it would be a bit broken from user point of view if the link was not there on the start site ;) .
Comment 16 Felix Botner univentionstaff 2013-10-01 16:47:12 CEST
(In reply to Stefan Gohmann from comment #8)
> Please move the Nagios link to the administration tab.

OK

(In reply to Alexander Kläser from comment #9)
> univention-doc has now an entry in the services tab and points to
> /univention-doc which is in the old layout. I would suggest to remove the
> ...

OK 

univention-doc, univention-management-console-doc and univention-management-console-frontend-doc now have their own ucs-overview entry (i was unable to build univention-management-console-frontend-doc but that is a different story -> Bug #32782)

(In reply to Dirk Wiesenthal from comment #12)
> (In reply to Stefan Gohmann from comment #8)
> > Please move the Nagios link to the administration tab.
> 
> It should be possible to let the App Center handle that. See Bug#32609

the nagios app has no WebInterface= and no UCSOverviewCategory= entry. The ucs-overview integration is handled by the package
Comment 17 Alexander Kläser univentionstaff 2013-10-02 17:57:08 CEST
(In reply to Felix Botner from comment #16)
> ...
> the nagios app has no WebInterface= and no UCSOverviewCategory= entry. The
> ucs-overview integration is handled by the package

I guess it would be nice to add the following lines to the nagios .ini file:

  WebInterface=/nagios
  UCSOverviewCategory=False

Then App Center will not add UCR variables, but it will show the link to the site nevertheless.
Comment 18 Alexander Kläser univentionstaff 2013-10-04 18:29:41 CEST
The link for the documentation of univention-doc itself is missing, if I am correct.
Comment 19 Alexander Kläser univentionstaff 2013-10-04 18:30:08 CEST
I converted the .svg file to .png.
Comment 20 Felix Botner univentionstaff 2013-10-07 14:14:56 CEST
(In reply to Alexander Kläser from comment #17)
> 
> I guess it would be nice to add the following lines to the nagios .ini file:
> 
>   WebInterface=/nagios
>   UCSOverviewCategory=False
> 
> Then App Center will not add UCR variables, but it will show the link to the
> site nevertheless.

OK

(In reply to Alexander Kläser from comment #18)
> The link for the documentation of univention-doc itself is missing, if I am
> correct.

No, ucs-overview -> Univention development documentation
Comment 21 Erik Damrose univentionstaff 2013-10-31 12:34:00 CET
Update from 3.1: OK
New 3.2 install: OK
Changelog: OK
Comment 22 Stefan Gohmann univentionstaff 2013-11-19 06:44:31 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".