Univention Bugzilla – Bug 33008
Nobody calls ldap_available.sh anymore
Last modified: 2021-05-25 16:02:17 CEST
Created attachment 5539 [details] ldap_available.sh in Python ldap_available.sh was last called in UCS-3.0 ucs-3.0/ucs/base/univention-system-setup/usr/share/univention-system-setup/univention-system-setup: testpipe = os.popen('/usr/lib/univention-system-setup/scripts/ldap_available.sh') So after running setup-join.sh the file /var/run/univention-system-setup.ldap is created containing "no-ldap". The file is not removed explicitly, but only after reboot by /lib/init/bootclean.sh. Until then no LDAP objects are updated by calling UMC basic setup again. It should probably be called once from umc/python/setup/util.py#run_scripts() just before calling the scripts. It should also be rewritten in Python anyway, see attached patch.
/usr/lib/univention-system-setup/scripts/setup-join.sh contains: echo "no-ldap" > /var/run/univention-system-setup.ldap should this be changed to the script-call, too?
This issue has been filed against UCS 4.2. UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed. If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
As there we no further bug reports regarding no-ldap, just remove the unused script. [feature/ucs5] 64695cdbb6 Bug #33008 USS: Remove unused ldap_available.sh base/univention-system-setup/debian/changelog | 1 + .../scripts/ldap_available.sh | 41 ---------------------- doc/changelog/changelog-5.0-0.xml | 2 +- 3 files changed, 2 insertions(+), 42 deletions(-)
Is more cleanup necessary? Removing the "no-ldap" evaluation? Is this another bug?
(In reply to Florian Best from comment #4) > Is more cleanup necessary? > Removing the "no-ldap" evaluation? Is this another bug? Another bug as I lacked the deep understanding.
OK: ldap_available.sh has been removed OK: changelog entry
UCS 5.0 has been released: https://docs.software-univention.de/release-notes-5.0-0-en.html https://docs.software-univention.de/release-notes-5.0-0-de.html If this error occurs again, please use "Clone This Bug".