Bug 33255 - The join progress bar does not show the name of the currently executed join script
The join progress bar does not show the name of the currently executed join s...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Domain join
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 5.0-1-errata
Assigned To: Christian Castens
Florian Best
:
: 30203 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-11 16:03 CET by Dirk Wiesenthal
Modified: 2022-06-08 16:50 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.103
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize, Troubleshooting, Usability
Max CVSS v3 score:
best: Patch_Available+


Attachments
patch (1.81 KB, patch)
2016-01-19 11:23 CET, Florian Best
Details | Diff
patch (2.41 KB, patch)
2016-01-19 11:30 CET, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2013-11-11 16:03:22 CET
(1) The progressbar shows the name of the last executed join script, not the currently executed join script.
(2) "component" is always "Executing join scripts", "info" is always "Executing join script %s", at least I haven't seen anything else. This does not give enough information for something as crucial as the join process. "component" should be "Executing join script %s", "info" should be the last line of the log file.
Comment 1 Florian Best univentionstaff 2013-11-11 16:12:42 CET
yes…

What else information do you want to see?

The Log-polling had been replaced by the progressbar.

Currently stdout of univention-join is parsed which doesn't give any further information.
Comment 2 Stefan Gohmann univentionstaff 2013-11-22 06:51:37 CET
(In reply to Dirk Wiesenthal from comment #0)
> (1) The progressbar shows the name of the last executed join script, not the
> currently executed join script.

Yes that makes it in-transparent.

(In reply to Dirk Wiesenthal from comment #0)
> "component" should be "Executing join script %s", "info" should be the last
> line of the log file.

Does it really help to show all internal logfile lines in the GUI?
Comment 3 Dirk Wiesenthal univentionstaff 2013-11-22 10:14:20 CET
(In reply to Stefan Gohmann from comment #2)
> (In reply to Dirk Wiesenthal from comment #0)
> > "component" should be "Executing join script %s", "info" should be the last
> > line of the log file.
> 
> Does it really help to show all internal logfile lines in the GUI?

Does it really help to show all dpkg output lines in the App Center? The line itself may not be very relevant, but some scripts take a lot of time in large environments. The log lines could help verifying the script is up and running. If $(tail -f)ing the log file is too complicated, it is not necessary. But this is the common way of using the "info" field in the ProgressBar. Any other ideas?
Comment 4 Florian Best univentionstaff 2016-01-19 11:23:02 CET
Created attachment 7416 [details]
patch
Comment 5 Florian Best univentionstaff 2016-01-19 11:25:34 CET
(In reply to Florian Best from comment #4)
> Created attachment 7416 [details]
> patch
The patch only fixes that the currently executed joinscript is displayed. No more additional input e.g. tailing of the logfile.
Comment 6 Florian Best univentionstaff 2016-01-19 11:30:42 CET
Created attachment 7417 [details]
patch

This is btw really useful when only executing a few or one joinscript as in that case nothing is displayed at all currently!
Comment 7 Florian Best univentionstaff 2016-10-10 16:42:00 CEST
*** Bug 30203 has been marked as a duplicate of this bug. ***
Comment 8 Florian Best univentionstaff 2019-03-06 18:24:20 CET
Still in UCS 4.4 and even worse in large environments, where it shows 'Running pre-joinscripts hook(s)' all the time until the longest joinscript 03univention-directory-listener.inst is finished.

The patch is in UCS@school since years, iirc slightly adapted.
Comment 10 Florian Best univentionstaff 2022-05-23 14:15:46 CEST
We also have to integrate UCS@school's git:19ea669ce2854d9413d407f9b10301c4fd475292.
Comment 11 Christian Castens univentionstaff 2022-06-01 16:27:06 CEST
When executing join scripts via UMC module "Domain Join" the progress bar will now display the name of the currently running script instead of the last script that was finished.
Additionally some error handling was added and logging was cleaned up.

Package: univention-join
Version: 12.0.3-14A~5.0.0.202206011612
Branch: ucs_5.0-0
Scope: errata5.0-1

git:4f017f810f62bbb390a30e9d237bc1677c8ea98a
git:983a31a3f4a8dcf304bda7abe436b5e540721a68
git:7115d802dd48047127a855ca12e98f1c356fb498
git:527403c02af9a9b30f1be8f0e4f523026d3b33cc
git:8a6399a37a672d0d8c825aebd04a8c53b57ba6aa
Comment 12 Florian Best univentionstaff 2022-06-01 16:39:23 CEST
OK: currently executed joinscript is shown
OK: error handling
OK: refactoring
OK: YAML
~OK: the join hooks are not detected, especially in UCS@school it then shows a long time just "authenticating" while the join hooks are running.