Univention Bugzilla – Bug 33698
Share definition does not get removed if samba option is disabled
Last modified: 2022-12-20 09:59:35 CET
Seen at ticket #2013120621005229: If disabling the "samba" option within UMC at a share, the share definition in filesystem (/etc/samba/shares.conf.d/) won't be removed. Seems to be related to the listener module, I suppose this should be done there. Discovered in UCS 3.1-1, reproduceable with UCS 3.2
The module is shipped as part of univention-samba.
Created attachment 8787 [details] fixbug33698.patch Apparently the listener only calls the module if the objectclass filter specified in the module matches the new object: '(&(objectClass=univentionShare)(objectClass=univentionShareSamba))' The attached patch fixes this: * let the module be called also if only the old object had the samba option * sanitize the share path (against ../../../../etc/passwd) * skip samba reload in postrun in case the handler didn't need to do anything
Created attachment 8789 [details] fixbug33698.patch This one applies to univention-samba.