Bug 34738 - Remove extra empty line from listener log
Remove extra empty line from listener log
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Listener (univention-directory-listener)
UCS 3.2
All Linux
: P5 minor (vote)
: UCS 4.1-2-errata
Assigned To: Philipp Hahn
Arvid Requate
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-02 15:42 CEST by Philipp Hahn
Modified: 2016-10-17 16:20 CEST (History)
0 users

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
34739.diff (2.60 KB, patch)
2016-10-17 14:29 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2014-05-02 15:42:41 CEST
Several debug output commands add an additional newline after their message. This leads to empty lines in /var/log/univention/listener.log.
IMHO they should be removed, as they breaking reading the log.

$ git grep -n 'univention_debug.*\\n'
src/cache_entry.c:440:          univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "ALERT:     %s differs\n", *cur);
src/cache_entry.c:447:                  univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "ALERT:         lentry = []\n");
src/cache_entry.c:456:                  univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "]\n");
src/cache_entry.c:464:                  univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "ALERT:         rentry = []\n");
src/cache_entry.c:473:                  univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "]\n");
src/cache_entry.c:486:          univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "ALERT:     module %s on lentry missing on rentry\n", *cur1);
src/cache_entry.c:494:          univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "ALERT:     module %s on rentry missing on lentry\n", *cur2);
src/network.c:114:      univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ALL, ">>>\n%s\n", buf);
src/network.c:143:              univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ALL, "RESULT: [%s]\n", result);
src/network.c:176:      univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ALL, "<<<\n%s\n", *back);
src/transfile.c:61:             univention_debug(UV_DEBUG_LDAP, UV_DEBUG_WARN, "Could not open lock file [%s]\n", buf);
src/transfile.c:70:             univention_debug(UV_DEBUG_LDAP, UV_DEBUG_INFO, "Could not get lock for file [%s]; count=%d\n", buf, count);
src/transfile.c:73:                     univention_debug(UV_DEBUG_TRANSFILE, UV_DEBUG_ERROR, "Could not get lock for file [%s]; exit\n", buf);
src/transfile.c:80:             univention_debug(UV_DEBUG_LDAP, UV_DEBUG_WARN, "Could not open file [%s]\n", name);
src/transfile.c:126:                    univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "Could not open %s\n", transaction_file);
src/transfile.c:136:            univention_debug(UV_DEBUG_LISTENER, UV_DEBUG_ERROR, "Could not write to transaction file %s. Check for %s\n", transaction_file, failed_ldif_file);
Comment 1 Philipp Hahn univentionstaff 2016-06-07 18:09:39 CEST
r69898 | Bug #34738 UDL: Remove empty lines from debug output

Package: univention-directory-listener
Version: 10.0.0-11.315.201606071717
Branch: ucs_4.1-0
Scope: errata4.1-2

r69910 | Bug #22383,Bug #30227,Bug #30263,Bug #34324,Bug #34507,Bug #34738,Bug #3490,Bug #38696,Bug #39509,Bug #40600,Bug #41261: UDL YAML
 univention-directory-listener.yaml
Comment 2 Arvid Requate univentionstaff 2016-07-13 18:58:52 CEST
Code review: Ok
Advisory: Ok

Taste differs, in some of the error and warning messages I like the extra visual clue of a vertical offset, but I may be alone with this preference.
Comment 3 Janek Walkenhorst univentionstaff 2016-07-21 15:16:03 CEST
<http://errata.software-univention.de/ucs/4.1/215.html>
Comment 4 Philipp Hahn univentionstaff 2016-10-17 14:29:01 CEST
Created attachment 8116 [details]
34739.diff

123b23d Bug #34739 log: Switch hash implementation
Comment 5 Philipp Hahn univentionstaff 2016-10-17 16:20:33 CEST
Comment on attachment 8116 [details]
34739.diff

Wrong bug