Bug 35574 - UMC module ad connection does not handle ADNotAvailable exception from test_connection
UMC module ad connection does not handle ADNotAvailable exception from test_c...
Status: RESOLVED WONTFIX
Product: UCS
Classification: Unclassified
Component: AD Connector
UCS 4.2
Other Linux
: P5 normal (vote)
: ---
Assigned To: Samba maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-05 14:47 CEST by Felix Botner
Modified: 2020-07-03 20:54 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.006
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Error handling
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Botner univentionstaff 2014-08-05 14:47:06 CEST
In _enable_ssl_and_test_connection() in management/console/modules/adconnector/__init__.py test_connection() is used. test_connection()raises ADNotAvailable() if the ad connection can't be established. But this exception is not handled in _enable_ssl_and_test_connection(). 

This happens e.g. if i upload a certifacte which is not yet valid.

management-console-module-adconnector.log:
05.08.14 14:44:41.822  MODULE      ( PROCESS ) : Enable connector SSL
05.08.14 14:44:42.038  MODULE      ( WARN    ) : Traceback (most recent call last):
  File "/usr/sbin/univention-adsearch", line 167, in <module>
    lo.start_tls_s()
  File "/usr/lib/python2.6/dist-packages/ldap/ldapobject.py", line 526, in start_tls_s
    return self._ldap_call(self._l.start_tls_s)
  File "/usr/lib/python2.6/dist-packages/ldap/ldapobject.py", line 96, in _ldap_call
    result = func(*args,**kwargs)
ldap.CONNECT_ERROR: {'info': 'error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed (certificate is not yet valid)', 'desc': 'Connect error'}

05.08.14 14:44:42.152  MODULE      ( ERROR   ) : Traceback (most recent call last):
  File "/usr/sbin/univention-management-console-module", line 114, in <module>
    notifier.loop()
  File "/usr/lib/pymodules/python2.6/notifier/nf_generic.py", line 284, in loop
    step()
  File "/usr/lib/pymodules/python2.6/notifier/nf_generic.py", line 276, in step
    __min_timer = dispatch.dispatcher_run()
  File "/usr/lib/pymodules/python2.6/notifier/dispatch.py", line 72, in dispatcher_run
    if not disp():
  File "/usr/lib/pymodules/python2.6/notifier/popen.py", line 290, in _watcher
    proc.dead( pid, status )
  File "/usr/lib/pymodules/python2.6/notifier/popen.py", line 169, in dead
    self.signal_emit( 'killed', pid, status )
  File "/usr/lib/pymodules/python2.6/notifier/signals.py", line 75, in signal_emit
    self.__signals[ signal ].emit( *args )
  File "/usr/lib/pymodules/python2.6/notifier/signals.py", line 41, in emit
    cb( *args )
  File "/usr/lib/pymodules/python2.6/notifier/popen.py", line 419, in _finished
    self.signal_emit( 'finished', pid, exit_code ,self.__stdout, self.__stderr )
  File "/usr/lib/pymodules/python2.6/notifier/signals.py", line 75, in signal_emit
    self.__signals[ signal ].emit( *args )
  File "/usr/lib/pymodules/python2.6/notifier/signals.py", line 41, in emit
    cb( *args )
  File "/usr/lib/pymodules/python2.6/notifier/__init__.py", line 104, in __call__
    return self._function( *tmp, **self._kwargs )
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/adconnector/__init__.py", line 272, in _return
    self._enable_ssl_and_test_connection(fn)
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/adconnector/__init__.py", line 533, in _enable_ssl_and_test_connection
    success = test_connection()
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/adconnector/__init__.py", line 84, in test_connection
    raise ADNotAvailable()
ADNotAvailable
Comment 1 Stefan Gohmann univentionstaff 2017-06-16 20:37:39 CEST
This issue has been filed against UCS 3. UCS 3 is out of the normal maintenance and many UCS components have vastly changed in UCS 4.

If this issue is still valid, please change the version to a newer UCS version otherwise this issue will be automatically closed in the next weeks.
Comment 2 Ingo Steuwer univentionstaff 2020-07-03 20:54:28 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.