Bug 35707 - Listener log level (listener.log) messages should be reviewed
Listener log level (listener.log) messages should be reviewed
Status: NEW
Product: UCS
Classification: Unclassified
Component: Listener (univention-directory-listener)
UCS 4.4
Other Linux
: P5 minor with 11 votes (vote)
: UCS 4.x
Assigned To: UCS maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-26 16:48 CEST by Dmitry Galkin
Modified: 2019-01-12 16:42 CET (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments
Unify UDL log message format (117.98 KB, patch)
2017-03-06 13:44 CET, Philipp Hahn
Details | Diff
UV_DEBUG_LDAP -> UV_DEBUG_LISTENER (5.60 KB, patch)
2018-11-13 15:54 CET, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Galkin univentionstaff 2014-08-26 16:48:26 CEST
Currently the test 00_base/99check_log_files shows:

Errors found in '/var/log/univention/listener.log':

 E: listener.log:28, 25.08.14 18:00:11.973  LISTENER    ( ERROR   ) : connection to notifier was closed
 E: listener.log:29, 25.08.14 18:00:11.973  LISTENER    ( ERROR   ) : failed to recv result
 E: listener.log:30, 25.08.14 18:00:11.973  LISTENER    ( ERROR   ) : listener: 1
 E: listener.log:32, 25.08.14 18:00:17.259  LDAP        ( ERROR   ) : start_tls: Can't contact LDAP server
 E: listener.log:36, 25.08.14 18:01:18.308  LDAP        ( ERROR   ) : start_tls: Can't contact LDAP server
 E: listener.log:95, 25.08.14 18:09:31.166  LISTENER    ( ERROR   ) : well-known-sid-name-mapping.d/univention-ldap-server.py: postrun: Initiating graceful reload of ldap server(s).
 E: listener.log:106, 25.08.14 18:10:08.709  LISTENER    ( ERROR   ) : well-known-sid-name-mapping.d/univention-ldap-server.py: postrun: Initiating graceful reload of ldap server(s).
 E: listener.log:117, 25.08.14 18:10:13.520  LISTENER    ( WARN    ) : error searching DN cn=Domain Admins,cn=groups,dc=autotest093,dc=local: -1
 E: listener.log:118, 25.08.14 18:10:13.520  LISTENER    ( ERROR   ) : change_update_dn: Can't contact LDAP server
 E: listener.log:119, 25.08.14 18:10:29.173  LISTENER    ( ERROR   ) : well-known-sid-name-mapping.d/univention-ldap-server.py: postrun: Initiating graceful reload of ldap server(s).


Some of those seem to be just a debug messages with an "ERROR" level. Should be reviewed.
Comment 1 Philipp Hahn univentionstaff 2017-02-22 11:53:18 CET
We should change SIGUSR1/SIGUSR2 to make UDL reload the debug setting and apply them to to currently running process.

We should support multiple facilities, as debugging cache_lowlevel.c is almost never of interest and it logs too much with DEBUG.

We should log to syslog which would allow us to forward the messages to a central log server more easily, which makes debugging a distributed system like UDL/UDN much better.
Comment 2 Philipp Hahn univentionstaff 2017-03-06 13:44:02 CET
Created attachment 8495 [details]
Unify UDL log message format

The attached patch converts all univention_debug() users to use the common format
 __FILE__:__LINE__:__func__: msg...
The old explicit logging of __xxx___has been removed manually.

It also converts all users to use UV_DEBUG_LISTENER and UV_DEBUG_TRANSFILE, as currently it's a mixed mess. UV_DEBUG_LDAP is not used anymore, but still enabled for UDL modules.

What is still needed is more categories, e.g. verbose logging for the main event loop, but no logging for low-level cache handling details.

We should wait for Bug #43685 to decide on a future logging framework.
Comment 3 Philipp Hahn univentionstaff 2018-11-13 15:54:56 CET
Created attachment 9742 [details]
UV_DEBUG_LDAP -> UV_DEBUG_LISTENER

The log messages are from UDL not not related to LDAP, so use
UV_DEBUG_LISTENER instead of UV_DEBUG_LDAP.