Univention Bugzilla – Bug 36789
UCS4 design incomplete in UCS@school modules
Last modified: 2017-04-11 17:45:41 CEST
There are several module where the UCS4 design in incomplete, e.g. the module for assigning teachers to classes has no save button at the top right, but a "Änderungen speichern" button at the lower right, which is outside of the screen so the user has to scoll down to be able to click it.
All other modules have to be checked too.
Please do not make any changes directly in ucs-school-4.1r2 but attach a patch to this bug, that contains all neccessary changes.
Hm shouldn't we wait for UCS 4.2 here as there might be several more changes?!
Created attachment 8136 [details] Patches for all relevant modules.
I have made the changes after talking to Florian and Alex.
(In reply to Richard Ulmer from comment #5) > I have made the changes after talking to Florian and Alex. You didn't commit anything, right? Setting the Bug back to Assigned.
The "save" button for the distribution module is not called "Create project" anymore when adding a project. I am not sure if we should keep the label. The label is only displayed when hovering the save icon. Why did you remove the height of the helpdesk text area field?
The "save" button for the distribution module is now called "Create project", when creating a new project. I have removed the height, because it lead to problems when trying to extend the TextArea by dragging the lower-right-corner downwards. Trying to use the "rows" attribute of dojo did not work - I've added a comment to the code mentioning this. The design of the helpdesk module has been refined further with the help of Florian.
Created attachment 8193 [details] Patches for all relevant modules.
*** Bug 35057 has been marked as a duplicate of this bug. ***
*** Bug 43028 has been marked as a duplicate of this bug. ***
Slightly raised pain value due to some customer feedback.
I think it is better for UCS@school 4.2 so that teachers don't get confused :P
@Richard: you can apply the changes now in the UCS@school 4.2 branch!
Thanks for the patches! I applied them: ucs-school-umc-installer (5.0.0-2): r76845 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-wizards (9.0.1-1): r76846 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-helpdesk (13.0.0-2): r76841 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-internetrules (13.0.0-2): r76842 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-exam (7.0.1-1): r76839 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-computerroom (9.0.5-1): r76836 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-distribution (15.0.1-1): r76838 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-rooms (14.0.0-2): r76844 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-csv-import (4.0.1-1): r76837 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-groups (7.0.0-2): r76840 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard ucs-school-umc-lessontimes (5.0.0-2): r76843 | Bug #36789: adjust header buttons to new UMC design; applied patch from Richard
This looks great! I see only two issues: The UCS@school installation wizard has 2 close buttons, if the system is already configured. The save button of the school wizards are on the bottom and not in the top.
The "Advanced settings" button of the school wizards should be shown as headerButton.
The UCS@school installation wizard now has one close button, if the system is already configured. svn commit: 77498 build: 5.0.0-5A~4.2.0.201703091113
I've put the "Advanced settings"-button into the header. svn commit: 77538 build: 9.0.2-3A~4.2.0.201703091736
Created attachment 8517 [details] Screenshot of "Users (schools)" There is an additional column whose name is not readable. a) what column is it? b) please fix it
(In reply to Sönke Schwardt-Krummrich from comment #20) > Created attachment 8517 [details] > Screenshot of "Users (schools)" > > There is an additional column whose name is not readable. > a) what column is it? > b) please fix it It was a column used as workaround for the old grid to add some left padding, I guess. I removed this. ucs-school-umc-wizards (9.0.3-1): r77602 | Bug #36789: removed leftover from old grid
FYI, I adjusted the code of umc/widgets/Page such that one can specify fullWidth=true in order to make sure that the content area takes the full width of the page. The navigation area will then be positioned above the content (as for smaller screen sizes). This might be helpful for some UCS@school modules, as well.
The rest will be done at Bug #44089.
We also need to adapt the search input fields and add fullWidth to the search pages.
r 78382 ucs-school-umc-distribution (15.0.1-2) * Bug #36789: adapt search form to new UMC design r 78384 ucs-school-umc-groups (7.0.0-3) * Bug #36789: adapt search form to new UMC design r 78385 ucs-school-umc-printermoderation (14.0.3-2) * Bug #36789: adapt search form to new UMC design r 78386 ucs-school-umc-rooms (14.0.0-3) * Bug #36789: adapt search form to new UMC design r 78387 ucs-school-umc-users (13.0.0-2) * Bug #36789: adapt search form to new UMC design r 78388 ucs-school-umc-wizards (9.0.3-2) * Bug #36789: adapt search form to new UMC design
r 78392 r 78393 ucs-school-umc-internetrules (13.0.0-3) * Bug #36789: adapt search form to new UMC design
There is a "Change school" button below the grid of the "Users (schools)" wizard. As the grid has now unlimited scrolling this needs to be moved to the top module buttons.
(In reply to Florian Best from comment #27) > There is a "Change school" button below the grid of the "Users (schools)" > wizard. As the grid has now unlimited scrolling this needs to be moved to > the top module buttons. r 78438 ucs-school-umc-wizards (9.0.3-3) * Bug #36789: Move 'Change school' button in Users (schools) module into module header
brilliant!
UCS@school 4.2 v1 has been released. http://docs.software-univention.de/release-notes-ucsschool-4.2v1-de.html If this error occurs again, please clone this bug.