Bug 37337 - special characters in object names produce a traceback
special characters in object names produce a traceback
Status: CLOSED FIXED
Product: UCS Test
Classification: Unclassified
Component: UDM
unspecified
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Florian Best
Stefan Gohmann
: interim-1
: 8052 (view as bug list)
Depends on:
Blocks: 43332
  Show dependency treegraph
 
Reported: 2014-12-15 10:52 CET by Ammar Najjar
Modified: 2017-04-04 18:28 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments
patch (1.83 KB, patch)
2016-09-15 13:58 CEST, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ammar Najjar univentionstaff 2014-12-15 10:52:34 CET
Test script created for bug #8052:
63_udm-containers.05_container_ou_recursive_removal_with_special_characters.

test Traceback (most recent call last):
  File "05_container_ou_recursive_removal_with_special_characters", line
28, in <module>
    udm.move_object('container/ou', dn = ou, position = ou2)
  File "/usr/lib/pymodules/python2.7/univention/testing/udm.py", line
256, in move_object
    raise UCSTestUDM_MoveUDMObjectFailed({'module': modulename,
'kwargs': kwargs, 'returncode': child.returncode, 'stdout': stdout,
'stderr': stderr})
univention.testing.udm.UCSTestUDM_MoveUDMObjectFailed: {'returncode': 3,
'stdout': 'ldap Error: Bad search filter\n', 'stderr': '', 'module':
'container/ou', 'kwargs': {'dn':
'ou=\xc3\x9ftd\xc3\x9f\xe2\x82\xac:\xc5\xb7**\xc3\xbb,dc=autotest203,dc=loca
l', 'position':
'ou=\xc3\x9fde\xce\xa9|_\xc4\x9d{\xc3\xbc1,dc=autotest203,dc=local'}}


Special characters which were used in the test were ( !#$%&*-/:?@[]^_`{|}~´€Ω®½)
One of them must have triggered this traceback.

for now the (*) is removed from the group for now, as it is the one problematic character in the mentioned traceback, and some others as well such as \()=+" 
(the script should use a random set of special characters). 
please re-add or comment when this bug is fixed.
Comment 1 Florian Best univentionstaff 2016-09-15 13:58:05 CEST
Created attachment 8013 [details]
patch

This is fixed meanwhile. We should reactivate the tests and revert the changes in ucs-test. Patch attached.
Comment 2 Florian Best univentionstaff 2016-10-11 10:25:50 CEST
Bug #8052 was not solved correctly. All LDAP filter and DN escaping were missing so that the test scripts were wrong. I added this escaping everywhere and readded the missing special characters.

ucs-test (7.0.6-12):
r73075 | Bug #37337: Bug #8052: Fix escaping of DN's and LDAP filters; revert svn r56733
Comment 3 Florian Best univentionstaff 2016-10-11 10:25:59 CEST
*** Bug 8052 has been marked as a duplicate of this bug. ***
Comment 4 Florian Best univentionstaff 2016-12-02 16:30:10 CET
No QA required.
Comment 6 Florian Best univentionstaff 2017-01-12 18:53:04 CET
ucs-test (7.0.6-45):
r75729 | Bug #37337: Bug #8052: fix escaping
r75720 | Bug #37337: Bug #8052: fix typo
r75719 | Bug #37337: Bug #8052: fix typo
Comment 7 Stefan Gohmann univentionstaff 2017-01-30 06:18:14 CET
OK
Comment 8 Stefan Gohmann univentionstaff 2017-04-04 18:28:23 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".