Bug 38232 - Policy violation: /etc/init.d/univention-s4-connector not idempotent
Policy violation: /etc/init.d/univention-s4-connector not idempotent
Status: RESOLVED WORKSFORME
Product: UCS
Classification: Unclassified
Component: S4 Connector
UCS 4.2
Other Linux
: P5 minor (vote)
: ---
Assigned To: Samba maintainers
:
Depends on: 35557
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-10 16:51 CEST by Philipp Hahn
Modified: 2020-07-04 08:35 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:
best: Patch_Available+


Attachments
s4c: Fix init behaviour (8.82 KB, patch)
2015-04-10 16:51 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2015-04-10 16:51:59 CEST
Created attachment 6818 [details]
s4c: Fix init behaviour

Stopping the S4C multiples times fails:
> # /etc/init.d/univention-s4-connector stop
> [info] Stopping univention-s4-connector daemon.
> done.
> # /etc/init.d/univention-s4-connector stop
> [info] Stopping univention-s4-connector daemon.
> start-stop-daemon: warning: failed to kill 6505: No such process
> failed.

This is in violation of <https://www.debian.org/doc/debian-policy/ch-opersys.html#s-writing-init>:
> The init.d scripts must ensure that they will behave sensibly (i.e., returning success [...] with stop when it isn't [running ...]

+++ This bug was initially created as a clone of Bug #35557 +++
Comment 3 Ingo Steuwer univentionstaff 2020-07-03 20:51:47 CEST
This issue has been filed against UCS 4.2.

UCS 4.2 is out of maintenance and many UCS components have changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer UCS versions, please use "Clone this bug" or reopen it and update the UCS version. In this case please provide detailed information on how this issue is affecting you.
Comment 4 Philipp Hahn univentionstaff 2020-07-04 08:35:05 CEST
This is fixed because systemd is used, which handles this case correctly.