Bug 40032 - Validate App metadata on integrity
Validate App metadata on integrity
Status: NEW
Product: UCS Test
Classification: Unclassified
Component: App Center
unspecified
Other Linux
: P5 normal (vote)
: ---
Assigned To: App Center maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-19 10:51 CET by Nico Gulden
Modified: 2016-10-21 18:50 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Gulden univentionstaff 2015-11-19 10:51:50 CET
There should be automated tests that check the app metadata on integrity. There are the .ini and .meta files. Both have attributes. The checks should include the following:

1) All mandatory attributes are defined in the metadata.
2) References to files like logos or app appliance images should check for existence of the files.
3) Links should be checked that they are available

There may be more checks useful. Please add appropriately.
Comment 1 Stefan Gohmann univentionstaff 2015-11-20 06:39:28 CET
(In reply to Nico Gulden from comment #0)
> 1) All mandatory attributes are defined in the metadata.

Which attributes are mandatory for the files in order to match the website requirements?
Comment 2 Nico Gulden univentionstaff 2015-11-20 09:46:15 CET
(In reply to Stefan Gohmann from comment #1)
> (In reply to Nico Gulden from comment #0)
> > 1) All mandatory attributes are defined in the metadata.
> 
> Which attributes are mandatory for the files in order to match the website
> requirements?

For the App catalog the following attributes are needed:

* .ini: ID, Name, ShortDescription, Description, Version, Website, Thumbnails, Vendor, VendorWebsite, Maintainer, MaintainerWebsite, Contact, SupportOptions, LogoDetailPage

* .meta: ID, DetailpageOnCatalogue, TeaserpageOnCatalogue, UniventionApp
Comment 3 Philipp Hahn univentionstaff 2015-11-20 10:24:32 CET
We already have some checks:
$ grep desc: ucs-test/tests/20_appcenter/1?_check_apps_ini*
ucs-test/tests/20_appcenter/10_check_apps_ini:## desc: Simple check if App's .ini(s) can be used.
ucs-test/tests/20_appcenter/11_check_apps_ini_field_values:## desc: Check if App .ini has values in settings that are present.
ucs-test/tests/20_appcenter/12_check_apps_ini_all_fields:## desc: Checks Apps .ini field values, description length, optional values.

IMHO they should be moved to some "pre-publish-to-app-center" stage instead of every ucs-test instance checking the same ini files again and again.
Comment 4 Stefan Gohmann univentionstaff 2016-01-19 15:21:56 CET
(In reply to Philipp Hahn from comment #3)
> IMHO they should be moved to some "pre-publish-to-app-center" stage instead
> of every ucs-test instance checking the same ini files again and again.

No, we should better use ucs-test for this because we will send the ucs-test output to the ISV. So, the ISV can re-check the ini file.