Bug 41117 - ucs-school-lib should search for user objects via ucsschoolSchool attribute
ucs-school-lib should search for user objects via ucsschoolSchool attribute
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Ucsschool-lib
UCS@school 4.1
Other Linux
: P5 normal (vote)
: UCS@school 4.1 R2
Assigned To: Florian Best
Daniel Tröder
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-25 17:12 CEST by Florian Best
Modified: 2016-06-28 18:24 CEST (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2016-04-25 17:12:42 CEST
The ucsschool-lib has to be adapted to search for the object classes with the new attribute "ucsschoolSchool" when searching for all types of users.

The result set of that search has to be merged with the current result which uses the OU in the DN as indicator for the school.
Comment 1 Florian Best univentionstaff 2016-05-26 17:13:06 CEST
ucs-school-lib (9.0.1-2):
r69565 | Bug #41117: user User.get_all() to search for users
r69554 | Bug #41117: adjust User.get_all() to also find school users in diferrent OU's
r69408 | Bug #41117: search for users everywhere using the new attributes
r69323 | Bug #41117: enhancements
r69003 | Bug #41117: add some helper functions; add Schools Attribute
r69002 | Bug #41117: enhance LDAP_Connection decorator

Until here all places are covered. I need a special look on:
1.) performace: when searching for only users of a specific group
→ currently it searches for all users, call .open() and then filter the ones
2.) error handling. previously arround .open() error handling exists. The UCS@school lib doesn't do such error handling. should we implement this in the UCS@school lib?
Comment 2 Florian Best univentionstaff 2016-06-03 17:19:21 CEST
As far as i can see everything has been implemented.

ucs-school-umc-wizards (8.0.0-1):
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-umc-helpdesk (12.0.2-1):
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-umc-exam (6.0.4-1):
r69800 | Bug #41117: adjust is_(student|teacher|administrator|staff) for

ucs-school-umc-printermoderation (13.0.2-1):
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-test-ucsschool (3.0.5-41):
r69778 | Bug #41117: remove unnecessary use of search_base
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-roleshares (4.0.0-1):
r69778 | Bug #41117: remove unnecessary use of search_base

ucs-school-umc-computerroom (8.0.2-1):
r69797 | Bug #41117: adjust is_(student|teacher|administrator|staff) for

ucs-school-lib (9.0.9-1):
r69801 | Bug #41117: restrict schools to local schools by group membership
r69800 | Bug #41117: adjust is_(student|teacher|administrator|staff) for
r69797 | Bug #41117: adjust is_(student|teacher|administrator|staff) for
r69778 | Bug #41117: remove unnecessary use of search_base
r69734 | Bug #41117: detect User class depending on objectClass
r69637 | Bug #41117: fix typos in last commit
r69621 | Bug #41117: fix fuzzy
r69620 | Bug #41117: filter out non-local schools
r69565 | Bug #41117: user User.get_all() to search for users
r69554 | Bug #41117: adjust User.get_all() to also find school users in diferrent OU's
r69408 | Bug #41117: search for users everywhere using the new attributes
r69323 | Bug #41117: enhancements
r69003 | Bug #41117: add some helper functions; add Schools Attribute
r69002 | Bug #41117: enhance LDAP_Connection decorator

ucs-school-umc-distribution (14.0.2-1):
r69797 | Bug #41117: adjust is_(student|teacher|administrator|staff) for
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-umc-users (12.0.1-1):
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-s4-branch-site (4.0.0-1):
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-umc-groups (6.0.2-1):
r69797 | Bug #41117: adjust is_(student|teacher|administrator|staff) for
r69735 | Bug #41117: remove unnecessary use of search_base

ucs-school-umc-installer (4.0.0-3):
r69778 | Bug #41117: remove unnecessary use of search_base
Comment 3 Daniel Tröder univentionstaff 2016-06-15 10:06:26 CEST
OK: UCS@school lib has been modified to work with the ucsschoolSchool attribute instead of the ou from the DN.
OK: cleanup unnecessary use of search_base

I added a test for is_*() functions in r70193 to 107_user_model_change.

Thanks for a lot of cleanup work!
Comment 4 Florian Best univentionstaff 2016-06-28 18:24:56 CEST
UCS@school 4.1 R2 has been released:
http://docs.software-univention.de/release-notes-ucsschool-4.1R2v1-de.pdf

If this error occurs again, please use "Clone This Bug".