Bug 42863 – Teachers classes gets removed if teacher is modified via school wizards module

Bug 42863 - Teachers classes gets removed if teacher is modified via school wizards module


Summary:	Teachers classes gets removed if teacher is modified via school wizards module

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - Wizards
Version:	UCS@school 4.1 R2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.1 R2 vXXX
Assigned To:	Florian Best
QA Contact:	Sönke Schwardt-Krummrich

URL:
Keywords:	interim-2

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-11-07 13:25 CET by Florian Best
Modified:	2016-11-10 16:00 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.257
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Flags:	best: Patch_Available+

Attachments
patch (3.23 KB, patch) 2016-11-07 13:25 CET, Florian Best	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2016-11-07 13:25:03 CET

Created attachment 8200 [details]
patch

If a teacher is modified in the "Users (schools)" module he gets removed from all his assigned classes.

This is because the frontend hides the 'class' widget, so the value is not send along to the backend. The internal backend handling is wrong because the initial/old values aren't set.

Patch attached.

Comment 1 Florian Best

2016-11-07 13:38:41 CET

ucs-school-umc-wizards (8.0.0-12):
r74174 | Bug #42863: don't remove teacher from classes when editing her

ucs-school-umc-wizards.yaml:
r74174 | Bug #42863: don't remove teacher from classes when editing her

Comment 2 Sönke Schwardt-Krummrich

2016-11-08 13:59:18 CET

ucs-test-ucsschool (3.0.16-43):
r74222 | Bug #42863: adjusted essential/user.py to reproduce UMC behaviour

ucs-school-umc-wizards.yaml:
r74221 | Bug #42863: updated advisory


OK: code change
OK: functional test
OK: ucs-test
    (essential/user.py adjusted to reproduce UMC behaviour; test 70_users_module 
     now fails with old version and succeeds with 8.0.0-12)
OK: advisory

Comment 3 Sönke Schwardt-Krummrich

2016-11-10 16:00:43 CET

UCS@school 4.1 R2 v7 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.1R2v7-de.html

If this error occurs again, please clone this bug.