Bug 45445 - Improve styling for Single Sign-On error page
Improve styling for Single Sign-On error page
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: SAML
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 4.4-5-errata
Assigned To: Florian Best
Johannes Keiser
:
: 45410 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-22 18:00 CEST by Johannes Keiser
Modified: 2020-08-26 16:35 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Design, SAML
Max CVSS v3 score:


Attachments
Screenshot_1 (53.65 KB, image/png)
2017-09-22 18:01 CEST, Johannes Keiser
Details
Screenshot_2 (67.58 KB, image/png)
2017-09-22 18:01 CEST, Johannes Keiser
Details
Screenshot patched (63.90 KB, image/png)
2020-08-11 09:19 CEST, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2017-09-22 18:00:44 CEST
The styling for the simplesamlphp error page should be improved.

Looking at the screenshots, some points are:
- The button with the image is way too big
- The textarea with the trackid is too small (content not visible)
- No spacing between the text and left/right window border
Comment 1 Johannes Keiser univentionstaff 2017-09-22 18:01:13 CEST
Created attachment 9230 [details]
Screenshot_1
Comment 2 Johannes Keiser univentionstaff 2017-09-22 18:01:32 CEST
Created attachment 9231 [details]
Screenshot_2
Comment 3 Florian Best univentionstaff 2020-06-22 18:21:47 CEST
*** Bug 45410 has been marked as a duplicate of this bug. ***
Comment 4 Florian Best univentionstaff 2020-08-11 09:19:26 CEST
Created attachment 10454 [details]
Screenshot patched

I created a patch for the styling of the site in git:fbest/45445-saml-error-styling.
If no javascript is available the current page is shown.
Comment 5 Florian Best univentionstaff 2020-08-19 21:00:52 CEST
The styling of the SAML error page has been adapted to match the styling of UMC errors.

Examples are:
/simplesamlphp/module.php/core/loginuserpass.php?
/simplesamlphp/module.php/

You can also add throw new Exception('foo'); to /usr/share/simplesamlphp/modules/core/www/loginuserpass.php

univention-saml (6.0.2-48)
64693cd337ce | Bug #45445: display UMC error dialog
4583c303a82e | Bug #45445: copy default simplesamlphp error template
univention-saml.yaml
7cfe2919999a | YAML Bug #45445

univention-management-console (11.0.4-102)
10418c0ebd8e | Bug #45445: use umc.tools.showErrorDialog
univention-management-console.yaml
7cfe2919999a | YAML Bug #45445

univention-web (3.0.5-40)
5742e6d9c3e8 | Bug #45445: add umc.tools.showErrorDialog
univention-web.yaml
7cfe2919999a | YAML Bug #45445
Comment 6 Johannes Keiser univentionstaff 2020-08-26 11:08:55 CEST
OK: saml errors are now shown in the saml style as UMC errors.
OK: yaml
-> verified