Bug 45863 - univention-mozilla-firefox provides wrong pref.js
univention-mozilla-firefox provides wrong pref.js
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.2
Other Linux
: P5 enhancement (vote)
: UCS 4.3
Assigned To: Jürn Brodersen
Stefan Gohmann
: interim-2
Depends on: 42322
Blocks: 45864 46120
  Show dependency treegraph
 
Reported: 2017-12-12 18:06 CET by Philipp Hahn
Modified: 2018-03-14 14:38 CET (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.051
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2017-12-12 18:06:26 CET
+++ This bug was initially created as a clone of Bug #42322 +++
Comment 1 Philipp Hahn univentionstaff 2017-12-12 18:16:36 CET
$ find desktop/univention-mozilla-firefox/conffiles/ -type f
desktop/univention-mozilla-firefox/conffiles/etc/firefox-esr/pref/firefox-esr.js
desktop/univention-mozilla-firefox/conffiles/etc/mozilla-firefox/pref/firefox.js
desktop/univention-mozilla-firefox/conffiles/opt/firefox/defaults/pref/firefox.js

None of those files are currently read by firefox-esr.
Correct is /etc/firefox-esr/firefox-esr.js

You also don't need to overwrite that file: it is enough to provide another files next to it; for example '/etc/firefox-esr/univention.js'

(I verified that by adding different pref("fooX","valX"); to those files and checking <about:config>: Only those values where set of files in /etc/firefox-esr/)
Comment 2 Philipp Hahn univentionstaff 2017-12-12 18:20:27 CET
The UCR variable descriptions are all wrong: They still reference "/opt/firefox", while "/usr/lib/firefox-esr" is correct.
Comment 4 Jürn Brodersen univentionstaff 2018-03-02 15:06:43 CET
[4.3-0 e60286fe54] Bug #45863 firefox: Fix location of UCR template
[4.3-0 25478e8486] Bug #45863: Update UCR templates for Debian Stretch
[4.3-0 b1b756e8d0] Bug #45863: Fix typo ucr variable description
[4.3-0 63d4ba30da] Bug #45863: Merge branch 'juern/b45863_firefox_ucr' into 4.3-0
[4.3-0 37cab14238] Bug #45863: Set firefox startpage on first installation
[4.3-0 db7c34e5c3] Bug #45863, #46253: Changelog
Comment 5 Stefan Gohmann univentionstaff 2018-03-05 15:25:43 CET
Currently, I'm unable to start firefox-esr. The following message is shown: "Failed to read the configuration file. Please contact your system administrator."

After moving /etc/firefox-esr/univention.js to /tmp, I was able to start firefox.

The content of univention.js:

root@master431:~# cat /tmp/univention.js 
// Warning: This file is auto-generated and might be overwritten by
//          univention-config-registry.
//          Please edit the following file(s) instead:
// Warnung: Diese Datei wurde automatisch generiert und kann durch
//          univention-config-registry ueberschrieben werden.
//          Bitte bearbeiten Sie an Stelle dessen die folgende(n) Datei(en):
// 
// 	/etc/univention/templates/files/etc/firefox-esr/univention.js
// 

pref("general.config.obscure_value", 0);
pref("browser.shell.checkDefaultBrowser", "false");
pref("general.config.filename", "univention.cfg");
pref("browser.startup.homepage", "https://www.univention.de/");
pref("network.negotiate-auth.trusted-uris", "deadlock43.intranet");
pref("startup.homepage_welcome_url", "https://www.univention.de/");
pref("browser.startup.homepage_reset", "https://www.univention.de/");

root@master431:~#
Comment 6 Philipp Hahn univentionstaff 2018-03-05 16:26:26 CET
(In reply to Stefan Gohmann from comment #5)
> Currently, I'm unable to start firefox-esr. The following message is shown:
> "Failed to read the configuration file. Please contact your system
> administrator."
...
> root@master431:~# cat /tmp/univention.js 
...
> pref("general.config.filename", "univention.cfg");

Do you have the following symbolic link and file:
 /usr/lib/firefox-esr/univention.cfg -> /etc/firefox-esr/univention.cfg
Comment 7 Jürn Brodersen univentionstaff 2018-03-05 16:29:42 CET
found it. I used lstrip und rstrip wrong... :(
Comment 8 Jürn Brodersen univentionstaff 2018-03-05 16:37:51 CET
[4.3-0 1d51a8e688] Bug #45863: fix univention.cfg

Version: 12.0.0-6A~4.3.0.201803051634
Comment 9 Stefan Gohmann univentionstaff 2018-03-05 19:55:50 CET
Yes, works now.
Comment 10 Stefan Gohmann univentionstaff 2018-03-14 14:38:45 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".