Bug 46253 - Check UCR templates files for Debian-Stretch updates - dsktop/univention-kde
Check UCR templates files for Debian-Stretch updates - dsktop/univention-kde
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Jürn Brodersen
Stefan Gohmann
: interim-2
Depends on:
Blocks: 46120
  Show dependency treegraph
 
Reported: 2018-02-08 11:52 CET by Philipp Hahn
Modified: 2018-03-14 14:38 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2018-02-08 11:52:43 CET
+++ This bug was initially created as a clone of Bug #46120 +++

desktop/univention-kde/conffiles/usr/share/apps/kdeprint/specials.desktop → kprinter4?
desktop/univention-kde/conffiles/usr/share/apps/kdesktop/DesktopLinks/OpenOffice.desktop → LibreOffice?
desktop/univention-kde/conffiles/usr/share/apps/kdesktop/DesktopLinks/mozilla.desktop → firefox?
...

diff --git a/desktop/univention-kde/conffiles/usr/share/univention-kde-profiles/kde4-menu/.kde/share/config/kickoffrc b/desktop/univention-kde/conffiles/usr/share/univention-kde-profiles/kde4-menu/.kde/share/config/kickoffrc
index b6dbe45c17..97dcae7310 100644
--- a/desktop/univention-kde/conffiles/usr/share/univention-kde-profiles/kde4-menu/.kde/share/config/kickoffrc
+++ b/desktop/univention-kde/conffiles/usr/share/univention-kde-profiles/kde4-menu/.kde/share/config/kickoffrc
@@ -2,25 +2,15 @@
 
 [Favorites]
 @!@
-import os.path
+from os.path import isfile
 
 defFavorites = (
-       "/usr/share/applications/kde/Kontact.desktop",
-       "/usr/share/applications/kde4/Kontact.desktop",
-       "/usr/share/applications/firefox.desktop",
-       "/usr/share/applications/openoffice.org-startcenter.desktop",
-       "/usr/share/applications/kde4/dolphin.desktop",
+       "/usr/share/applications/org.kde.kontact.desktop",
+       "/usr/share/applications/firefox-esr.desktop",
+       "/usr/share/applications/libreoffice-startcenter.desktop",
+       "/usr/share/applications/org.kde.dolphin.desktop",
        "/usr/share/applications/univention.desktop",
 )
 
-favorites = ""
-
-for application in defFavorites:
-    if os.path.isfile(application):
-        favorites += application + ","
-
-if len(favorites) != 0:
-    favorites = favorites[:-1]
-
-print "FavoriteURLs=%s" % (favorites)
+print "FavoriteURLs=%s" % (','.join(fav for fav in defFavorites if isfile(fav),)
 @!@
Comment 1 Philipp Hahn univentionstaff 2018-02-08 13:53:42 CET
proposed patch: (partial)
<https://git.knut.univention.de/univention/ucs/commit/54f66f62fcf2e952a989366d7913391daf307c55>
Comment 2 Jürn Brodersen univentionstaff 2018-03-02 14:53:03 CET
[4.3-0 ffab769aff] Bug #46253: Updates for debian stretch
[4.3-0 870cae3584] Bug #46253: Register new files in univention-config-registry
[4.3-0 720d8ba8a8] Bug #46253: fix path in univention-config-registry
[4.3-0 f5ca110ab1] Bug #46253: firefox https desktop link
[4.3-0 4795a2724f] Bug #46253: add maintscript for old templates
[4.3-0 db7c34e5c3] Bug #45863, #46253: Changelog

Note:
commit f5ca110ab1 is possible because of fix in bug 45864
Comment 3 Stefan Gohmann univentionstaff 2018-03-04 20:32:10 CET
Three issues:

- The Univention splash is not used.

- The favorites aren't configured. Previously, the filemanager and the server administration (firefox) were shown in the favorites menu. 

- Now, some icons are shown on the desktop.
Comment 4 Jürn Brodersen univentionstaff 2018-03-05 12:21:35 CET
(In reply to Stefan Gohmann from comment #3)
> Three issues:
> 
> - The Univention splash is not used.

Afaik that is not possible anymore. ksplashx was used for that which is not supported in kde5. I might be able to use a static image though.

> 
> - The favorites aren't configured. Previously, the filemanager and the
> server administration (firefox) were shown in the favorites menu. 
> 
> - Now, some icons are shown on the desktop.

Should the icons stay on the desktop or should they only be shown as favorites?
Comment 5 Jürn Brodersen univentionstaff 2018-03-05 18:49:51 CET
c4f8d1b3: fix splash because ksplashx is deprecated; add umc desktop link to favorites

Version: 12.0.0-7A~4.3.0.201803051815
Comment 6 Stefan Gohmann univentionstaff 2018-03-05 20:20:01 CET
(In reply to Jürn Brodersen from comment #5)
> c4f8d1b3: fix splash because ksplashx is deprecated; add umc desktop link to
> favorites

No, it doesn't work on my system. I don't see a splash and the favorites folder is empty. In addition, the wallpaper is the Debian default wallpaper.
Comment 7 Jürn Brodersen univentionstaff 2018-03-06 10:50:41 CET
(In reply to Stefan Gohmann from comment #6)
> (In reply to Jürn Brodersen from comment #5)
> > c4f8d1b3: fix splash because ksplashx is deprecated; add umc desktop link to
> > favorites
> 
> No, it doesn't work on my system. I don't see a splash and the favorites
> folder is empty. In addition, the wallpaper is the Debian default wallpaper.

Sorry, forgot one commit :(

[4.3-0 b17ddd1f08] Bug #46253: add usr/ to  univention-kde.install
[4.3-0 7177af80f0] Bug #46253: only show dolphin and umc desktop link in favorites
Package: univention-kde
Version: 12.0.0-9A~4.3.0.201803061011
Comment 8 Stefan Gohmann univentionstaff 2018-03-06 12:22:24 CET
(In reply to Jürn Brodersen from comment #7)
> (In reply to Stefan Gohmann from comment #6)
> > (In reply to Jürn Brodersen from comment #5)
> > > c4f8d1b3: fix splash because ksplashx is deprecated; add umc desktop link to
> > > favorites
> > 
> > No, it doesn't work on my system. I don't see a splash and the favorites
> > folder is empty. In addition, the wallpaper is the Debian default wallpaper.
> 
> Sorry, forgot one commit :(
> 
> [4.3-0 b17ddd1f08] Bug #46253: add usr/ to  univention-kde.install
> [4.3-0 7177af80f0] Bug #46253: only show dolphin and umc desktop link in
> favorites
> Package: univention-kde
> Version: 12.0.0-9A~4.3.0.201803061011

Thanks, that looks much better.
Comment 9 Stefan Gohmann univentionstaff 2018-03-14 14:38:33 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".