Bug 46553 - two+ Python syntax errors in UCR conffiles
two+ Python syntax errors in UCR conffiles
Status: RESOLVED DUPLICATE of bug 49704
Product: UCS
Classification: Unclassified
Component: UCR
UCS 4.3
Other Linux
: P5 minor (vote)
: ---
Assigned To: UCS maintainers
UCS maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-08 16:03 CET by Philipp Hahn
Modified: 2020-06-22 13:40 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments
ucs-lint - should be added to ucslint (1.72 KB, text/plain)
2018-03-08 16:03 CET, Philipp Hahn
Details
ucslint flake8 check for conffiles/ (3.84 KB, patch)
2019-12-09 23:42 CET, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2018-03-08 16:03:24 CET
Created attachment 9453 [details]
ucs-lint - should be added to ucslint

<stdin>:18:32: invalid syntax
print 'BarBaz=%s' configRegistry.get('bar/baz/value', 'MyDefault').lower()
CRITICAL:FAIL: ./packaging/univention-package-template/conffiles/etc/ucsversion

<stdin>:13: undefined name 'protocols'
CRITICAL:FAIL: ./base/univention-base-files/conffiles/etc/ssh/sshd_config


Plus several cosmetic issues due to unused imports:

<stdin>:8: 'univention.appcenter.app_cache.Apps' imported but unused
CRITICAL:FAIL: ./management/univention-appcenter/conffiles/etc/univention/service.info/services/univention-appcenter.cfg

<stdin>:8: 'os.path' imported but unused
CRITICAL:FAIL: ./management/univention-ldap/conffiles/etc/ldap/slapd.conf.d/10univention-ldap-server_schema

<stdin>:9: 'os' imported but unused
CRITICAL:FAIL: ./management/univention-management-console/conffiles/usr/share/univention-management-console/meta.json

<stdin>:8: 'sys' imported but unused
CRITICAL:FAIL: ./base/univention-updater/conffiles/etc/apt/mirror.list

<stdin>:8: 'sys' imported but unused
CRITICAL:FAIL: ./base/univention-updater/conffiles/etc/apt/sources.list.d/15_ucs-online-version.list
<stdin>:8: 'sys' imported but unused
CRITICAL:FAIL: ./base/univention-updater/conffiles/etc/apt/sources.list.d/20_ucs-online-component.list

<stdin>:8: 're' imported but unused
CRITICAL:FAIL: ./mail/univention-mail-postfix/conffiles/etc/postfix/transport.d/10_base

<stdin>:9: 'grp' imported but unused
CRITICAL:FAIL: ./mail/univention-mail-dovecot/conffiles/etc/dovecot/conf.d/10-mail.conf
<stdin>:8: 'pwd' imported but unused
CRITICAL:FAIL: ./mail/univention-mail-dovecot/conffiles/etc/dovecot/conf.d/10-mail.conf

<stdin>:10: 'sys' imported but unused
CRITICAL:FAIL: ./mail/univention-mail-dovecot/conffiles/var/lib/dovecot/sieve/default.sieve

<stdin>:8: 'os.path' imported but unused
CRITICAL:FAIL: ./services/univention-samba4wins/conffiles/etc/ldap/slapd.conf.d/13univention-samba4wins.schema
Comment 1 Florian Best univentionstaff 2019-12-06 13:34:25 CET
univention-base-files
6b128c8b7021 | Bug #46553: remove UCR marker which are python comments and therefore not evaluated

univention-package-template
49604c6de8f9 | Bug #46553: fix typo in UCR template file
Comment 2 Florian Best univentionstaff 2019-12-09 23:42:03 CET
Created attachment 10257 [details]
ucslint flake8 check for conffiles/
Comment 3 Florian Best univentionstaff 2020-06-22 13:40:05 CEST

*** This bug has been marked as a duplicate of bug 49704 ***