Bug 48745 - Do not duplicate Virtual Hosts entries of Let's encrypt
Do not duplicate Virtual Hosts entries of Let's encrypt
Status: NEW
Product: UCS
Classification: Unclassified
Component: Let's Encrypt
UCS 4.4
Other Linux
: P5 normal (vote)
: ---
Assigned To: UCS maintainers
UCS maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-25 10:18 CET by Florian Best
Modified: 2019-09-19 07:31 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2019-02-25 10:18:27 CET
The letsencrypt app defines a VirtualHost for every domain (letsencrypt/domains).

Instead of creating one VirtualHost for every domain it should be possible to create a single VirtualHost with aliases for every other domain name.

<VirtualHost *:443>
        IncludeOptional /etc/apache2/ucs-sites.conf.d/*.conf
        ServerName example.com
        ServerAlias www.example.com
        ServerAlias www.example.net
        SSLEngine on
…
</VirtualHost>

Or does anything speak against this? I don't see any technical problem.
Comment 1 Jannik Ahlers univentionstaff 2019-02-26 08:50:50 CET
The idea with the virtual hosts was that you can use e.g. the ucs root certificate for your default domain and a letsencrypt one for any additional domains (see bug #48204).
Comment 2 Florian Best univentionstaff 2019-02-26 09:42:01 CET
(In reply to Jannik Ahlers from comment #1)
> The idea with the virtual hosts was that you can use e.g. the ucs root
> certificate for your default domain and a letsencrypt one for any additional
> domains (see bug #48204).

My proposal is not about having 1 virtual host entry at the end. You can have one for letsencrypt and one for the default UCS domain (=2 vhosts). But you don't need to create a virtual host for every let's encrypt domain but only one with all other domains as alias (as the content of the VHosts is always equal).