Bug 49104 - Tracking code 200 sent even when the installation was not successful
Tracking code 200 sent even when the installation was not successful
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-3-errata
Assigned To: Toni Röhmeyer
Dirk Wiesenthal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-03-26 14:59 CET by Dirk Wiesenthal
Modified: 2020-02-26 14:24 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted after Product Owner Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2019-03-26 14:59:22 CET
When the installation routine raises an exception at a very early stage, the error handling is erroneous and the untouched default status of 200 is sent.

Happens when the LDAP server is down. The installation does not start, yet we think the installation was successful.
Comment 1 Dirk Wiesenthal univentionstaff 2019-03-26 15:00:04 CET
Maybe this explains some discrepancies in the Appliance reporting?
Comment 2 Toni Röhmeyer univentionstaff 2020-01-29 12:25:15 CET
In actions/install_base.py some exceptions did not update the status code.
For those exceptions, a new error type "ResidualInstallationError" with the status code 502 was introduced.

The behavior can be tested by stopping the ldap server before installing an app.
The installation will now be acknowledged as failed.
Comment 3 Erik Damrose univentionstaff 2020-01-29 13:23:35 CET
Reopen:

Where did these changes happen, e.g. which commits in which git branch?

I can see there has been a rebuild of univention-appcenter in scope errata4.4-3, but no YAML for the package was commited. Please do that right after package build to ensure consistency and a stable errata release process
Comment 4 Toni Röhmeyer univentionstaff 2020-01-29 14:01:35 CET
Sorry, my mistake.

My commits

Bug #49104: yaml
Bug #49104: added yaml
Bug #49104: Added ResidualInstallationError (statuscode: 502)

are now on branch 4.4-3
Comment 5 Dirk Wiesenthal univentionstaff 2020-02-26 09:09:35 CET
Test was:
  service slapd stop
  univention-app install riot
Log was:
  send_information: action=install app=riot value=LDAP server is not running! status=502
=> OK

YAML: OK
Comment 6 Erik Damrose univentionstaff 2020-02-26 14:24:59 CET
<http://errata.software-univention.de/ucs/4.4/455.html>