Bug 49823 - Copyable user properties
Copyable user properties
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Users
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-6-errata
Assigned To: Christian Castens
Felix Botner
:
: 46199 (view as bug list)
Depends on:
Blocks: 52144
  Show dependency treegraph
 
Reported: 2019-07-05 15:33 CEST by Philipp Hahn
Modified: 2020-09-30 15:37 CEST (History)
5 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.011
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
castens: Patch_Available+


Attachments
patch (8.44 KB, patch)
2020-02-05 13:07 CET, Christian Castens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2019-07-05 15:33:11 CEST
UDM supports cloning existing users to create new users. Several properties are marked as copyable, which for a user do not make sense:
- firstname
- lastname
- gecos
- displayName
- employeeNumber
- homePostalAddress
- homeTelephoneNumber
- birthday
- jpegPhoto
- userCertificate
- certificate* (they are display-only, e.g. editable=False!)
- ...

They should not be copied by default.

UCS technical training 2019-06-27/28
UCS technical training 2019-05-08/09
Comment 1 Christian Castens univentionstaff 2020-02-05 13:07:32 CET
Created attachment 10289 [details]
patch

With the attached patch the following properties will not be copied anymore:

- firstname
- lastname
- gecos
- displayName
- title
- initials
- employeeNumber
- homePostalAddress
- mobileTelephoneNumber
- pagerTelephoneNumber
- birthday
- jpegPhoto
- userCertificate
- certificate*
Comment 2 Florian Best univentionstaff 2020-06-22 16:45:11 CEST
*** Bug 46199 has been marked as a duplicate of this bug. ***
Comment 3 Florian Best univentionstaff 2020-06-22 16:45:38 CEST
(In reply to Florian Best from comment #2)
> *** Bug 46199 has been marked as a duplicate of this bug. ***
When fixing make sure this is fixed as well.
Comment 5 Julia Bremer univentionstaff 2020-09-18 10:03:13 CEST
Patch applied and test added in ccastens/49823-copyable-user-properties and ready for QA.
TODO merge to 4.4-6.
Comment 6 Felix Botner univentionstaff 2020-09-21 11:43:16 CEST
checked ccastens/49823-copyable-user-properties

FAIL - jpegPhoto still copyable (copyable=True)




OK - no longer copyable  ...

ok - firstname
ok - lastname
ok - gecos
ok - displayName
ok - passwordexpiry
ok - employeeNumber
ok - homePostalAddress
ok - homeTelephoneNumber
ok - birthday
ok - userCertificate
ok - certificate*
ok - title
ok - initials
ok - mobileTelephoneNumber
ok - pagerTelephoneNumber
Comment 7 Felix Botner univentionstaff 2020-09-21 11:52:49 CEST
I also started the test on a "unmodified" UCS 4.4-5, and the test succeeded? So i guess there is some work to do there as well.
Comment 8 Christian Castens univentionstaff 2020-09-24 14:43:57 CEST
Package: univention-directory-manager-modules
Version: 14.0.16-2A~4.4.0.202009241414
Branch: ucs_4.4-0
Scope: errata4.4-6

revision after first QA:
jpegPhoto property has been removed from being copyable.

changed file:
management/univention-directory-manager-modules/modules/univention/admin/handlers/users/user.py

commits (4.4-6):
commit 19879e48b72d5a7dfbf1413a1d7803544e33ee98 (yaml)
commit 8d74b65614f93fb70a518ab25173082fcfb73c7e (changelog)
commit c52c30c1413f3983f8617da28bbb8be65c08c9e4 (new features)
Comment 9 Felix Botner univentionstaff 2020-09-24 16:58:33 CEST
OK - yaml (i made this change 570ca55b47fb9f6a073c4d2b1323b6b192152f33, hope this is OK)
OK - univention-directory-manager-modules.yaml

Please create merge request for to 5.0-0.
Comment 10 Christian Castens univentionstaff 2020-09-28 12:53:02 CEST
merge request for 5.0-0 created.
Comment 12 Felix Botner univentionstaff 2020-09-28 13:31:12 CEST
OK - merge request