Univention Bugzilla – Bug 50943
Add Python 3 support for univention-licence
Last modified: 2020-03-18 12:58:26 CET
$ python3 -c 'import univention.license' Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: No module named 'univention.license'
Before starting to implement, please look if it's already done in (git:python/4.4-3) (not sure): commit d0b96bd32c7b92fa74de82818ff93e5b875157b0 Author: Owen Synge <synge@univention.de> Date: Thu Dec 5 12:42:33 2019 +0100 add .gitignore files commit be36c2a181c1389b9725f350afef0c9256cc5178 Author: Florian Best <best@univention.de> Date: Fri Nov 29 10:19:28 2019 +0100 * commit 88a3f914fa6ca4aae18e1268552a8a7057751480 Author: Florian Best <best@univention.de> Date: Thu Nov 28 18:38:02 2019 +0100 changelog commit 8e419a64f82a2d3ac0fce4919e43a939c912fd60 Author: Owen Synge <synge@univention.de> Date: Thu Nov 28 12:28:27 2019 +0100 Allow module to be imported in python3 commit 4b65e3e2d2162168c38aa37fc5e44b7ec99e21c6 Author: Florian Best <best@univention.de> Date: Tue Oct 15 10:14:51 2019 +0200 Bug #49137: migrate univention-license to dh_python
(In reply to Florian Best from comment #1) > Before starting to implement, please look if it's already done in > (git:python/4.4-3) (not sure): commit d0b96bd32c7b92fa74de82818ff93e5b875157b0 -> incomplete commit be36c2a181c1389b9725f350afef0c9256cc5178 -> dropped commit 88a3f914fa6ca4aae18e1268552a8a7057751480 -> dropped commit 8e419a64f82a2d3ac0fce4919e43a939c912fd60 -> good and used for own work commit 4b65e3e2d2162168c38aa37fc5e44b7ec99e21c6 -> incomplete Code @ <https://git.knut.univention.de/univention/ucs/-/commits/phahn/50943-licence?utf8=%E2%9C%93&search=Bug+%2350943> Test @ <https://jenkins.knut.univention.de:8181/job/UCS%20Branch%20Test/290/> Pre-Merge-QA please.
> Pre-Merge-QA please. Code review Ok. > Test @ <https://jenkins.knut.univention.de:8181/job/UCS%20Branch%20Test/290/> Seems to have failed before even starting properly.
(In reply to Arvid Requate from comment #3) > > Pre-Merge-QA please. > > Code review Ok. > > > Test @ <https://jenkins.knut.univention.de:8181/job/UCS%20Branch%20Test/290/> > > Seems to have failed before even starting properly. See <https://taiga.knut.univention.de/project/oschwieg-ucs-core/task/1010?kanban-status=38> for the why. 2nd try @ <https://jenkins.knut.univention.de:8181/job/UCS%20Branch%20Test/291/console> which failed again: - it only upgraded to 4.4-2 (instead of 4.4-3) - the tests did not run (at least generated no output) Investigating...
[4.4-3] 49749f1067 Bug #50943 licence: Add Python 3 support Package: univention-licence Version: 10.0.0-4A~4.4.0.202003171616 Branch: ucs_4.4-0 Scope: errata4.4-3 Package: univention-license-python Version: 10.0.0-4A~4.4.0.202003171621 Branch: ucs_4.4-0 Scope: errata4.4-3 [4.4-3] e3a79d4daf Bug #50943: univention-licence-python 10.0.0-4A~4.4.0.202003171621 .../.gitignore | 0 .../debian/changelog | 0 .../debian/clean | 0 .../debian/compat | 0 .../debian/control | 0 .../debian/copyright | 0 .../debian/rules | 0 .../python/univention/__init__.py | 0 .../python/univention/py_license.c | 0 .../setup.py | 0 .../test.py | 0 doc/errata/staging/univention-licence.yaml | 10 ++++++++++ doc/errata/staging/univention-license-python.yaml | 10 ++++++++++ 13 files changed, 20 insertions(+)
FYI: The source package is named using "American Egnlish" mit 'c', while the binary packages still use the "British English" spelling with 's'. [4.4-3] 9cdac74101 Bug #50943 licence: Rename source package to AE .../.gitignore | 0 .../debian/changelog | 2 +- .../debian/clean | 0 .../debian/compat | 0 .../debian/control | 18 +++++++++--------- .../debian/copyright | 0 .../debian/rules | 0 .../python/univention/__init__.py | 0 .../python/univention/py_license.c | 0 .../setup.py | 0 .../test.py | 0 ...ense-python.yaml => univention-licence-python.yaml} | 6 +++--- doc/errata/staging/univention-licence.yaml | 2 +- 13 files changed, 14 insertions(+), 14 deletions(-) Package: univention-licence-python Version: 10.0.0-4A~4.4.0.202003180929 Branch: ucs_4.4-0 Scope: errata4.4-3 [4.4-3] 06588c8772 Bug #50943 licence: Rename source package to AE YAML doc/errata/staging/univention-licence-python.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Verified: * Merge commit 49749f1067: Ok * Combined changes from Coment 5 and Comment 6: Ok * univention-licence-python: AE source package name, BE binary package names and AE package descriptions * univention-licence: AE source package name, BE binary package names and BE package descriptions (as before) * Test results: Ok * Manual update and functional test: Ok * Advisories: Ok
<http://errata.software-univention.de/ucs/4.4/492.html> <http://errata.software-univention.de/ucs/4.4/492.html>
<http://errata.software-univention.de/ucs/4.4/499.html>