Attachment 6693 Details for Bug 37711 – patch (1)

[patch] patch (1)

37711.patch (text/plain), 1.94 KB, created by Florian Best on 2015-02-18 12:28:43 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Florian Best

Created: 2015-02-18 12:28:43 CET

Size: 1.94 KB

patch

obsolete

>diff --git a/ucs-4.0-1/management/univention-management-console-module-udm/umc/js/udm/DetailPage.js b/ucs-4.0-1/management/univention-management-console-module-udm/umc/js/udm/DetailPage.js
>index f4ce937..63ed9a5 100644
>--- a/ucs-4.0-1/management/univention-management-console-module-udm/umc/js/udm/DetailPage.js
>+++ b/ucs-4.0-1/management/univention-management-console-module-udm/umc/js/udm/DetailPage.js
>@@ -382,13 +382,13 @@ define([
> 			this._form.ready().then(lang.hitch(this, function() {
> 				var valuesChanged = this.haveValuesChanged() || this.havePolicyReferencesChanged();
> 				if (valuesChanged) {
>-					var changes = '\n<ul>';
>+					var changes = [];
> 					tools.forIn(this.getAlteredValues(), lang.hitch(this, function(key, value) {
> 						if (key === '$dn$') {
> 							return;
> 						}
> 						var widget = this._form.getWidget(key);
>-						if (widget) {
>+						if (widget && widget.get('visible')) {
> 							value = widget.get('value');
> 							if (value instanceof Array) {
> 								value = value.join(', ');
>@@ -400,15 +400,18 @@ define([
> 									}
> 								});
> 							}
>-							changes += lang.replace('<li>{tabName}{groupName} - {widgetName}: {value}</li>', {
>+							changes.push(lang.replace('<li>{tabName}{groupName} - {widgetName}: {value}</li>', {
> 								tabName: widget.$refTab$ ? widget.$refTab$.label: '',
> 								groupName: widget.$refTitlePane$ ? ' - ' + widget.$refTitlePane$.label: '',
> 								widgetName: widget.get('label') || key,
>-								value: value});
>+								value: value
>+							}));
> 						}
> 					}));
>-					changes += '</ul>';
>-					dialog.alert(_('The following empty properties were set to default values in the form. These values will be applied when saving.') + changes);
>+					if (changes.length) {
>+						changes = '\n<ul>' + changes.join('') + '</ul>';
>+						dialog.alert(_('The following empty properties were set to default values in the form. These values will be applied when saving.') + changes);
>+					}
> 				}
> 			}));
> 		},

Actions: View | Diff

Attachments on bug 37711: 6693