Univention Bugzilla – Attachment 7082 Details for
Bug 39077
S4 Connector identifies unknown DNS objects as dns/host_record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix_dnstype_comparison.patch
fix_dnstype_comparison.patch (text/plain), 961 bytes, created by
Arvid Requate
on 2015-08-04 15:40:48 CEST
(
hide
)
Description:
fix_dnstype_comparison.patch
Filename:
MIME Type:
Creator:
Arvid Requate
Created:
2015-08-04 15:40:48 CEST
Size:
961 bytes
patch
obsolete
>Index: modules/univention/s4connector/s4/dns.py >=================================================================== >--- modules/univention/s4connector/s4/dns.py (Revision 62605) >+++ modules/univention/s4connector/s4/dns.py (Arbeitskopie) >@@ -1146,11 +1146,11 @@ > if not dnsRecords: > return None > >- dns_types=[] >+ dns_types=set() > for dnsRecord in dnsRecords: > dnsRecord=dnsRecord.encode('latin1') > dnsRecord_DnssrvRpcRecord=ndr_unpack(dnsp.DnssrvRpcRecord, dnsRecord) >- dns_types.append(dnsRecord_DnssrvRpcRecord.wType) >+ dns_types.add(dnsRecord_DnssrvRpcRecord.wType) > > if dnsp.DNS_TYPE_PTR in dns_types: > return 'ptr_record' >@@ -1158,7 +1158,7 @@ > return 'alias' > elif dnsp.DNS_TYPE_SRV in dns_types: > return 'srv_record' >- elif dnsp.DNS_TYPE_A in dns_types or dnsp.DNS_TYPE_AAAA: >+ elif set((dnsp.DNS_TYPE_A, dnsp.DNS_TYPE_AAAA)) & dns_types: > return 'host_record' > > return None
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=7082">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 39077
: 7082