Attachment 7742 Details for Bug 41053 – untested patch which always sets default values

[patch] untested patch which always sets default values

41053.patch (text/plain), 1.34 KB, created by Florian Best on 2016-06-14 13:21:29 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Florian Best

Created: 2016-06-14 13:21:29 CEST

Size: 1.34 KB

patch

obsolete

>diff --git a/management/univention-directory-manager-modules/modules/univention/admin/handlers/__init__.py b/management/univention-directory-manager-modules/modules/univention/admin/handlers/__init__.py
>index bb3a432..02510a3 100644
>--- a/management/univention-directory-manager-modules/modules/univention/admin/handlers/__init__.py
>+++ b/management/univention-directory-manager-modules/modules/univention/admin/handlers/__init__.py
>@@ -666,7 +666,7 @@ def _create(self):
> 			# ... if property has no option or any required option is currently enabled
> 			options_match = bool(set(p.options) & set(self.options)) if getattr(self, 'options', []) and p.options else True
> 			if options_match and self.descriptions[name].default(self):
>-				self[name]
>+				self[name] = self.descriptions[name].default(self)
> 
> 		# iterate over all properties and call checkLdap() of corresponding syntax
> 		self._call_checkLdap_on_all_property_syntaxes()
>@@ -760,7 +760,7 @@ def _modify(self, modify_childs=1, ignore_license=0):
> 			# skip otherwise
> 			if getattr(self, 'options', []) and p.options and (set(p.options) & set(self.options)):
> 				if self.descriptions[name].default(self):
>-					self[name]
>+					self[name] = self.descriptions[name].default(self)
> 
> 		# iterate over all properties and call checkLdap() of corresponding syntax
> 		self._call_checkLdap_on_all_property_syntaxes()

Actions: View | Diff

Attachments on bug 41053: 7595 | 7742 | 7743 | 7885