Attachment 5348 Details for Bug 29714

[patch] Print tracebacks in UMC setup module.

umc-setup-print-traceback.patch (text/plain), 1.58 KB, created by Alexander Kläser on 2013-08-02 11:31 CEST

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander Kläser

Created: 2013-08-02 11:31 CEST

Size: 1.58 KB

patch

obsolete

>Index: umc/python/setup/__init__.py
>===================================================================
>--- umc/python/setup/__init__.py	(Revision 42979)
>+++ umc/python/setup/__init__.py	(Arbeitskopie)
>@@ -174,16 +174,14 @@
> 				# done :)
> 				self._finishedResult = True
> 				return True
>-			except:
>-				msg = '%s\n%s: %s\n' % (''.join(traceback.format_tb(thread.exc_info[2])), thread.exc_info[0].__name__, str(thread.exc_info[1]))
>-				MODULE.warn( 'Exception during saving the settings: %s\n%s' % (result, msg) )
> 			finally:
> 				obj._finishedLock.release()
> 
> 
> 		def _finished( thread, result ):
> 			if isinstance( result, BaseException ):
>-				MODULE.warn( 'Exception during saving the settings: %s' % str( result ) )
>+				msg = '%s\n%s: %s\n' % (''.join(traceback.format_tb(thread.exc_info[2])), thread.exc_info[0].__name__, str(thread.exc_info[1]))
>+				MODULE.warn( 'Exception during saving the settings: %s\n%s' % (result, msg) )
> 
> 		thread = notifier.threads.Simple( 'save',
> 			notifier.Callback( _thread, request, self ), _finished )
>@@ -242,7 +240,8 @@
> 
> 		def _finished( thread, result ):
> 			if isinstance( result, BaseException ):
>-				MODULE.warn( 'Exception during saving the settings: %s' % str( result ) )
>+				msg = '%s\n%s: %s\n' % (''.join(traceback.format_tb(thread.exc_info[2])), thread.exc_info[0].__name__, str(thread.exc_info[1]))
>+				MODULE.warn( 'Exception during saving the settings: %s\n%s' % (result, msg) )
> 
> 		thread = notifier.threads.Simple( 'save',
> 			notifier.Callback( _thread, request, self, request.options.get('username'), request.options.get('password')),_finished )

Actions: View | Diff

Attachments on bug 29714: 5348 | 5351