Attachment 5687 Details for Bug 33164

[patch] Add URI-escaping for title

33164_uvmm-novnc-title.diff (text/plain), 1.15 KB, created by Philipp Hahn on 2013-12-03 08:11 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Philipp Hahn

Created: 2013-12-03 08:11 CET

Size: 1.15 KB

patch

obsolete

>diff --git a/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js b/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js
>index 2cc4d98..7caf31a 100644
>--- a/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js
>+++ b/branches/ucs-3.2/ucs-3.2-0/virtualization/univention-virtual-machine-manager-daemon/umc/js/uvmm.js
>@@ -318,10 +318,12 @@ define([
> 		},
> 
> 		vncLink: function( ids, items ) {
>-			array.forEach(ids, function(id) {
>+			array.forEach(items, function(item) {
>+				var id = item.id;
> 				var uuid = id.slice(id.indexOf('#') + 1);
> 				var port = window.location.port ? ':' + window.location.port : '';
>-				var url = window.location.protocol + '//' + window.location.host + port + '/univention-novnc/vnc_auto.html?port=6080&path=?token=' + uuid;
>+				var title = encodeURIComponent(item.label + '@' + item.nodeName);
>+				var url = window.location.protocol + '//' + window.location.host + port + '/univention-novnc/vnc_auto.html?port=6080&path=?token=' + uuid + '&title=' + title;
> 				window.open(url, '_blank');
> 			});
> 		},

Actions: View | Diff

Attachments on bug 33164: 5687