From 3e1870c26c7cd339c66ace96cb0a7ddc2d1777f0 Mon Sep 17 00:00:00 2001 From: Garming Sam Date: Mon, 18 Sep 2017 09:55:21 +1200 Subject: [PATCH] kcc: Remove unused, untested KCC code This code tries to implement the full KCC algorithm, but never actually worked correctly. Removing this doesn't affect the full-mesh KCC. This code only attempted to calculate a graph using the "proper" algorithm, though it neglected to write its results back into the database. The full-mesh calculation occurs elsewhere. Signed-off-by: Garming Sam Reviewed-by: Douglas Bagnall Autobuild-User(master): Douglas Bagnall Autobuild-Date(master): Wed Sep 20 06:28:07 CEST 2017 on sn-devel-144 --- source4/dsdb/kcc/kcc_connection.c | 1 - source4/dsdb/kcc/kcc_topology.c | 3564 ------------------------------------- source4/dsdb/wscript_build | 2 +- 3 files changed, 1 insertion(+), 3566 deletions(-) delete mode 100644 source4/dsdb/kcc/kcc_topology.c diff --git a/source4/dsdb/kcc/kcc_connection.c b/source4/dsdb/kcc/kcc_connection.c index f85ed13..6a20dea 100644 --- a/source4/dsdb/kcc/kcc_connection.c +++ b/source4/dsdb/kcc/kcc_connection.c @@ -190,7 +190,6 @@ struct kcc_connection_list *kccsrv_find_connections(struct kccsrv_service *s, const char *attrs[] = { "objectGUID", "fromServer", NULL }; struct kcc_connection_list *list; TALLOC_CTX *tmp_ctx; - kcctpl_test(s); tmp_ctx = talloc_new(mem_ctx); if (!tmp_ctx) { diff --git a/source4/dsdb/wscript_build b/source4/dsdb/wscript_build index c7a4c16..29c6f0e 100644 --- a/source4/dsdb/wscript_build +++ b/source4/dsdb/wscript_build @@ -43,7 +43,7 @@ bld.SAMBA_LIBRARY('dsdb_garbage_collect_tombstones', private_library=True) bld.SAMBA_MODULE('service_kcc', - source='kcc/kcc_service.c kcc/kcc_connection.c kcc/kcc_topology.c kcc/kcc_periodic.c kcc/kcc_drs_replica_info.c', + source='kcc/kcc_service.c kcc/kcc_connection.c kcc/kcc_periodic.c kcc/kcc_drs_replica_info.c', autoproto='kcc/kcc_service_proto.h', subsystem='service', init_function='server_service_kcc_init', -- 1.9.1