Attachment 9834 Details for Bug 46198

[patch] Set autofill="new-password"

0001-Bug-46198-UMC-Fix-password-auto-fill.patch (text/plain), 6.67 KB, created by Philipp Hahn on 2019-02-11 16:34 CET

(hide)

Description:

Filename:

MIME Type:

Creator: Philipp Hahn

Created: 2019-02-11 16:34 CET

Size: 6.67 KB

patch

obsolete

>From 66f8af2c3edcd2aedd2042b44edbf7f4e52672d1 Mon Sep 17 00:00:00 2001
>Message-Id: <66f8af2c3edcd2aedd2042b44edbf7f4e52672d1.1549899110.git.hahn@univention.de>
>From: Philipp Hahn <hahn@univention.de>
>Date: Mon, 11 Feb 2019 15:45:00 +0100
>Subject: [PATCH] Bug #46198 UMC: Fix password auto-fill
>Organization: Univention GmbH, Bremen, Germany
>
>---
> .../univention-management-console/www/login/index.html     | 10 +++++-----
> .../univention-management-console/www/login/login.html     |  4 ++--
> management/univention-web/js/widgets/PasswordBox.js        | 14 ++++++++++----
> .../themes/univention/core/loginuserpass.php               |  4 ++--
> 4 files changed, 19 insertions(+), 13 deletions(-)
>
>diff --git a/management/univention-management-console/www/login/index.html b/management/univention-management-console/www/login/index.html
>index 0776692415..29b9b1b6f5 100644
>--- a/management/univention-management-console/www/login/index.html
>+++ b/management/univention-management-console/www/login/index.html
>@@ -29,25 +29,25 @@
> 					<div id="umcLoginNotices" class="umcLoginNotices"></div>
> 					<form id="umcLoginForm" name="umcLoginForm" action="blank.html" method="post" class="umcLoginForm" autocomplete="on">
> 						<label for="umcLoginUsername">
>-							<input id="umcLoginUsername" name="username" type="text" autocomplete="on">
>+							<input id="umcLoginUsername" name="username" type="text" autocomplete="username">
> 						</label>
> 						<label for="umcLoginPassword">
>-							<input id="umcLoginPassword" name="password" type="password" autocomplete="on">
>+							<input id="umcLoginPassword" name="password" type="password" autocomplete="current-password">
> 						</label>
> 						<input id="umcLoginSubmit" type="submit" name="submit" value="">
> 					</form>
> 					<form id="umcNewPasswordForm" name="umcLoginForm" action="blank.html" method="post" class="umcLoginForm" style="display: none;" autocomplete="off">
> 						<label for="umcLoginNewPassword">
>-							<input id="umcLoginNewPassword" name="new_password" type="password" autocomplete="off">
>+							<input id="umcLoginNewPassword" name="new_password" type="password" autocomplete="new-password">
> 						</label>
> 						<label for="umcLoginNewPasswordRetype">
>-							<input id="umcLoginNewPasswordRetype" type="password" autocomplete="off">
>+							<input id="umcLoginNewPasswordRetype" type="password" autocomplete="new-password">
> 						</label>
> 						<input id="umcNewPasswordSubmit" type="submit" name="submit" value="">
> 					</form>
> 					<form id="umcCustomPromptForm" name="umcCustomPromptForm" action="blank.html" method="post" class="umcLoginForm" style="display: none;" autocomplete="off">
> 						<label for="umcLoginCustomPrompt">
>-							<input id="umcLoginCustomPrompt" type="password" autocomplete="off">
>+							<input id="umcLoginCustomPrompt" type="password" autocomplete="current-password">
> 						</label>
> 						<input id="umcCustomPromptSubmit" type="submit" name="submit" value="">
> 					</form>
>diff --git a/management/univention-management-console/www/login/login.html b/management/univention-management-console/www/login/login.html
>index 0cf7157924..a8bc9cc0c0 100644
>--- a/management/univention-management-console/www/login/login.html
>+++ b/management/univention-management-console/www/login/login.html
>@@ -11,10 +11,10 @@
> 	<body>
> 		<form id="umcLoginForm" name="umcLoginForm" action="blank.html" method="post" class="umcLoginForm" autocomplete="on">
> 			<label for="umcLoginUsername">
>-				<input placeholder="Username" id="umcLoginUsername" name="username" type="text" autocomplete="on"/>
>+				<input placeholder="Username" id="umcLoginUsername" name="username" type="text" autocomplete="username"/>
> 			</label>
> 			<label for="umcLoginPassword">
>-				<input placeholder="Password" id="umcLoginPassword" name="password" type="password" autocomplete="on"/>
>+				<input placeholder="Password" id="umcLoginPassword" name="password" type="password" autocomplete="current-password"/>
> 				<input id="umcLoginSubmit" type="submit" name="submit" value="Login"/>
> 			</label>
> 		</form>
>diff --git a/management/univention-web/js/widgets/PasswordBox.js b/management/univention-web/js/widgets/PasswordBox.js
>index 63d4b7fbb4..0bebc5d28f 100644
>--- a/management/univention-web/js/widgets/PasswordBox.js
>+++ b/management/univention-web/js/widgets/PasswordBox.js
>@@ -30,12 +30,18 @@
> 
> define([
> 	"dojo/_base/declare",
>+	"dojo/dom-attr",
> 	"umc/widgets/TextBox",
> 	"umc/widgets/_FormWidgetMixin"
>-], function(declare, TextBox, _FormWidgetMixin) {
>+], function(declare, domAttr, TextBox, _FormWidgetMixin) {
> 	return declare("umc.widgets.PasswordBox", [ TextBox, _FormWidgetMixin ], {
>-		type: 'password'
>+		type: 'password',
>+		buildRendering: function() {
>+			this.inherited(arguments);
>+			domAttr.set(this, 'autocomplete', 'new-password');
>+		},
>+		postCreate: function() {
>+			this.inherited(arguments);
>+		}
> 	});
> });
>-
>-
>diff --git a/saml/univention-saml/simplesamlphp-modules/univentiontheme/themes/univention/core/loginuserpass.php b/saml/univention-saml/simplesamlphp-modules/univentiontheme/themes/univention/core/loginuserpass.php
>index 3316bffa38..9d9f894d1c 100644
>--- a/saml/univention-saml/simplesamlphp-modules/univentiontheme/themes/univention/core/loginuserpass.php
>+++ b/saml/univention-saml/simplesamlphp-modules/univentiontheme/themes/univention/core/loginuserpass.php
>@@ -21,10 +21,10 @@ if (isset($this->data['SPMetadata']['privacypolicy'])) {
> 					<div id="umcLoginNotices" class="umcLoginNotices" style="display: none;"></div>
> 					<form id="umcLoginForm" name="umcLoginForm" action="?" method="post" class="umcLoginForm" autocomplete="on">
> 						<label for="umcLoginUsername">
>-							<input placeholder="<?php echo htmlspecialchars($this->t('{login:username}')); ?>" id="umcLoginUsername" name="username" type="text" autocomplete="on"  tabindex="1" value="<?php echo htmlspecialchars($this->data['username']); ?>" <?php echo $this->data['forceUsername'] ? 'readonly' : ''; ?>/>
>+							<input placeholder="<?php echo htmlspecialchars($this->t('{login:username}')); ?>" id="umcLoginUsername" name="username" type="text" autocomplete="username"  tabindex="1" value="<?php echo htmlspecialchars($this->data['username']); ?>" <?php echo $this->data['forceUsername'] ? 'readonly' : ''; ?>/>
> 						</label>
> 						<label for="umcLoginPassword">
>-							<input placeholder="<?php echo htmlspecialchars($this->t('{login:password}')); ?>" id="umcLoginPassword" name="password" type="password" tabindex="2" autocomplete="on"/>
>+							<input placeholder="<?php echo htmlspecialchars($this->t('{login:password}')); ?>" id="umcLoginPassword" name="password" type="password" tabindex="2" autocomplete="current-password"/>
> 						</label>
> 						<div id="umcLoginWarnings" class="umcLoginWarnings">
> <?php
>-- 
>2.11.0
>

Actions: View | Diff

Attachments on bug 46198: 9748 | 9834