Bug 30823 – sysvol-sync does not check timestamps properly

Bug 30823 - sysvol-sync does not check timestamps properly


Summary:	sysvol-sync does not check timestamps properly

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba4
Version:	UCS 3.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 3.1-1-errata
Assigned To:	Arvid Requate
QA Contact:	Stefan Gohmann

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-03-19 16:29 CET by Arvid Requate
Modified:	2013-05-30 10:28 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2013-03-19 16:29:59 CET

The sysvol-sync script should preserve timestamps while copying GPOs from downstream DCs. Otherwise the second local "rsync -u" will never preserve files in /var/lib/samba/sysvol ind the S4-Connector host that are actually newer than the ones on the downstream DCs.

================================================================================
        ## step one: pull over network from downstream s4dc
        ## -> -t is missing here!
        univention-ssh-rsync /etc/machine.secret -aAX --delete \
                "${hostname}\$"@"${s4dc}":"${SYSVOL_PATH}"/ "$importdir" 2>/dev/null

        ## step two: sync into hot target dir with local filesystem sp
        rsync -auAX "$importdir"/ "$SYSVOL_PATH"
================================================================================

Comment 1 Arvid Requate

2013-05-07 20:14:51 CEST

Fixed in errata3.1-1 and ucs3.1-2.

Advisory: 2013-05-07-univention-samba4.yaml
Changelog: changelog-3.1-2.tex

Comment 2 Stefan Gohmann

2013-05-29 16:22:34 CEST

3.1-1 errata: OK, I was not able to reproduce this issue. The sync works like  expected.

YAML: OK

3.1-2: OK (Code comparison)

Changelog: OK

Comment 3 Moritz Muehlenhoff

2013-05-30 10:28:41 CEST

http://errata.univention.de/ucs/3.1/114.html