Bug 30944 - Review UCR variable descriptions for desktop packages
Review UCR variable descriptions for desktop packages
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 3.0
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Moritz Muehlenhoff
Philipp Hahn
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-28 14:37 CET by Moritz Muehlenhoff
Modified: 2013-11-19 06:43 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Muehlenhoff univentionstaff 2013-03-28 14:37:36 CET
The UCR variable descriptions for the packages in base/ should be reviewed:

- Are descriptions missing?
- Are they comprehensible and self-contained?
- Are the syntactical options obvious for the user?
- Quality of the English translation

./univention-mozilla-firefox/debian/univention-mozilla-firefox.univention-config-registry-variables
./univention-kde/debian/univention-kde.univention-config-registry-variables
./univention-ooffice2/debian/univention-ooffice2.univention-config-registry-variables
./univention-x-core/debian/univention-x-core.univention-config-registry-variables
./univention-gdm/debian/univention-gdm.univention-config-registry-variables
Comment 1 Moritz Muehlenhoff univentionstaff 2013-07-04 11:32:48 CEST
The UCR variable descriptions for the following packages have been revised:

univention-gdm
univention-kde
univention-mozilla-firefox
univention-ooffice2
univention-x-core

univention-flashplugin will be removed for 3.2, so it was skipped.
Comment 2 Philipp Hahn univentionstaff 2013-08-13 19:01:36 CEST
FAIL: svn41764: univention-gdn
 Changes all "Type=bool" to "Type=str". Why? Even when only "true" and "false" are accepted by gdm, "bool" is a lot closer than "str". It's not even used yet.
 s/directory exclusively writable to the user logging/... by the user .../
 s/Buttons/Schaltflächen/
 de: s/Themes/Designs/
 en: /s/designs/themes/

FAIL: svn41784: univention-gdm
  gdm/autostart/permitteduser is still used by conffiles/etc/X11/Xwrapper.config

FAIL: svn41831: univention-kde
 "hal/devices/group" only accepts a group name, not a single user! <http://dbus.freedesktop.org/doc/dbus-daemon.1.html>: group="group name or gid". For users there would be @user

OK: svn41861: univention-mozilla-firefox
  firefox/prefs/checkdefaultbrowser: s/Type=str/Type=bool/

OK: svn41998: univention-ooffice2

FAIL: svn41852,41855: univention-x-core
  xorg/module/load: How are multiple modules separated: blanks,comma, ...
  xorg/screen/DefaultDepth: still set in postinst; the description should only be removed of the setting is removed as well.
  s/Hertz/Hz/
Comment 3 Moritz Muehlenhoff univentionstaff 2013-08-19 14:13:40 CEST
(In reply to Philipp Hahn from comment #2)
> FAIL: svn41764: univention-gdn
>  Changes all "Type=bool" to "Type=str". Why? Even when only "true" and
> "false" are accepted by gdm, "bool" is a lot closer than "str". It's not
> even used yet.

See the other UCR variable revamp bug; only variables which are only accessed through is_ucr_true() are configured as Type=bool.

>  s/directory exclusively writable to the user logging/... by the user .../
>  s/Buttons/Schaltflächen/
>  de: s/Themes/Designs/
>  en: /s/designs/themes/

Fixed in revision 43269.
 
> FAIL: svn41784: univention-gdm
>   gdm/autostart/permitteduser is still used by
> conffiles/etc/X11/Xwrapper.config

This variable is an obsolete remnant from from the pre-TCS thin client support. I removed it from the templates to avoid confusion. The obsolete template will vanish when we move to a slimmer base desktop in a future release.

> FAIL: svn41831: univention-kde
>  "hal/devices/group" only accepts a group name, not a single user!
> <http://dbus.freedesktop.org/doc/dbus-daemon.1.html>: group="group name or
> gid". For users there would be @user

Fixed in revision 43270

> FAIL: svn41852,41855: univention-x-core
>   xorg/module/load: How are multiple modules separated: blanks,comma, ...
>   s/Hertz/Hz/

Fixed in revision 43271

>   xorg/screen/DefaultDepth: still set in postinst; the description should
> only be removed of the setting is removed as well.

There's Bug 31851 for that.
Comment 4 Philipp Hahn univentionstaff 2013-08-19 15:46:01 CEST
OK: Copyright 2013
OK: svn43269...43274
OK: dpkg-query -W univention-gdm univention-kde univention-x-core
univention-gdm  10.0.0-2.287.201308191404
univention-kde  8.0.0-2.250.201308191407
univention-x-core       7.0.0-4.132.201308191410
Comment 5 Stefan Gohmann univentionstaff 2013-11-19 06:43:19 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".