Bug 30947 - Review UCR variable descriptions for nagios packages
Review UCR variable descriptions for nagios packages
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 3.0
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Moritz Muehlenhoff
Philipp Hahn
: interim-1
: 23911 24151 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-28 14:40 CET by Moritz Muehlenhoff
Modified: 2013-11-19 06:41 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Muehlenhoff univentionstaff 2013-03-28 14:40:35 CET
The UCR variable descriptions for the packages in base/ should be reviewed:

- Are descriptions missing?
- Are they comprehensible and self-contained?
- Are the syntactical options obvious for the user?
- Quality of the English translation

./univention-nagios/debian/univention-nagios-common.univention-config-registry-variables
./univention-nagios/debian/univention-nagios-server.univention-config-registry-variables
./univention-nagios/debian/univention-nagios-client.univention-config-registry-variables
Comment 1 Moritz Muehlenhoff univentionstaff 2013-07-04 11:51:16 CEST
*** Bug 23911 has been marked as a duplicate of this bug. ***
Comment 2 Moritz Muehlenhoff univentionstaff 2013-07-04 14:22:00 CEST
*** Bug 24151 has been marked as a duplicate of this bug. ***
Comment 3 Moritz Muehlenhoff univentionstaff 2013-07-05 15:04:11 CEST
The UCR variable descriptions in univention-nagios have been revised. The other packages don't include UCR variable descriptions.
Comment 4 Philipp Hahn univentionstaff 2013-08-13 19:20:22 CEST
FAIL: svn42038,42084,42086: univention-nagios
 nagios/server/autostart: Type=bool
 nagios/server/refreshrate: Type=int
 nagios/server/checkexternalcmd: Type=bool
 nagios/server/theme: s/design//
 nagios/plugin/check_nrpe/timeout: s/the Nagios/& server/

FYI : "diese Variable deaktiviert" / "this variable can be deactivated": Either the "setting can be deactivated" or the "variable can be set to 'false'", but the variable itself can not be deactivated
Comment 5 Moritz Muehlenhoff univentionstaff 2013-08-14 14:55:12 CEST
(In reply to Philipp Hahn from comment #4)
> FAIL: svn42038,42084,42086: univention-nagios
>  nagios/server/refreshrate: Type=int

Changed to "int"

>  nagios/server/checkexternalcmd: Type=bool

It doesn't use is_true() conffiles/etc/nagios3/nagios.cfg, so it doesn't cover the full semantics of "Type=bool", e.g. it would not react on "true".

During the review I've only changed the type to bool if is_true() were used in all referenced templates/scripts.

>  nagios/server/autostart: Type=bool

Likewise, see above.

>  nagios/server/theme: s/design//

Fixed.

>  nagios/plugin/check_nrpe/timeout: s/the Nagios/& server/

Fixed.

-> Revision 43155
Comment 6 Philipp Hahn univentionstaff 2013-08-14 16:22:45 CEST
OK: svn43155

(In reply to Moritz Muehlenhoff from comment #5)
> It doesn't use is_true() conffiles/etc/nagios3/nagios.cfg, so it doesn't
> cover the full semantics of "Type=bool", e.g. it would not react on "true".

WTF: But it does cover all values of "str"?
IMHO "bool" does give a better hint at what value is accepted here than "str", even if not all variants of true/True/TRUE/1/on/On/ON/enable/Enable/ENABLE/enabled/Enabled/ENABLED/yes/Yes/YES are accepted.

Ignored for now...

OK: 7.0.0-3-242-201308141453
Comment 7 Stefan Gohmann univentionstaff 2013-11-19 06:41:54 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".