Bug 31185 - HTML in app description is not possible
HTML in app description is not possible
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - App-Center
UCS 3.1
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Dirk Wiesenthal
Alexander Kläser
: interim-1
Depends on:
Blocks: 31985
  Show dependency treegraph
 
Reported: 2013-04-25 11:46 CEST by Sönke Schwardt-Krummrich
Modified: 2013-11-19 06:44 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2013-04-25 11:46:26 CEST
Currently the app description will be displayed in app center as text-only. I think it is necessary to add some formatting information for this text:

"<b><strong><blink><underline>This is a preview version! It is NOT designated for production use!</underline></blink></strong></b>"
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2013-04-25 11:51:40 CEST
This is only broken if englisch is selected as language. With german language settings, HTML entities will be evaluated.
Comment 2 Sönke Schwardt-Krummrich univentionstaff 2013-04-25 15:01:28 CEST
The german app detail view renders HTML correctly. But the app shortcut that has been created during installtion in favorites titlepane also shows the description which does not render HTML.
Comment 3 Dirk Wiesenthal univentionstaff 2013-07-11 16:46:58 CEST
(In reply to Sönke Schwardt-Krummrich from comment #0)
> Currently the app description will be displayed in app center as text-only.
> I think it is necessary to add some formatting information for this text:
> 
> "<b><strong><blink><underline>This is a preview version! It is NOT
> designated for production use!</underline></blink></strong></b>"

I suggest not allowing HTML in ini files. Instead use README_INSTALLATION which will be introduced with Bug#31803

(In reply to Sönke Schwardt-Krummrich from comment #1)
> This is only broken if englisch is selected as language. With german
> language settings, HTML entities will be evaluated.

Now THAT is a bug! Removed HTML evaluation in localised values in
  univention-management-console-module-appcenter 3.0.4-1.148.201307111644
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2013-07-11 21:23:02 CEST
(In reply to Dirk Wiesenthal from comment #3)
> (In reply to Sönke Schwardt-Krummrich from comment #0)
> > Currently the app description will be displayed in app center as text-only.
> > I think it is necessary to add some formatting information for this text:
> > 
> > "<b><strong><blink><underline>This is a preview version! It is NOT
> > designated for production use!</underline></blink></strong></b>"
> 
> I suggest not allowing HTML in ini files. Instead use README_INSTALLATION
> which will be introduced with Bug#31803

Where is the difference between HTML in ini files and HTML in README_* files?
Comment 5 Dirk Wiesenthal univentionstaff 2013-07-12 01:08:02 CEST
(In reply to Sönke Schwardt-Krummrich from comment #4)
> (In reply to Dirk Wiesenthal from comment #3)
> > (In reply to Sönke Schwardt-Krummrich from comment #0)
> > > Currently the app description will be displayed in app center as text-only.
> > > I think it is necessary to add some formatting information for this text:
> > > 
> > > "<b><strong><blink><underline>This is a preview version! It is NOT
> > > designated for production use!</underline></blink></strong></b>"
> > 
> > I suggest not allowing HTML in ini files. Instead use README_INSTALLATION
> > which will be introduced with Bug#31803
> 
> Where is the difference between HTML in ini files and HTML in README_* files?

There is none. But HTML clutters the ini file whereas HTML in the README_* files feels... less wrong. At least they seem to be made for markup.
Comment 6 Stefan Gohmann univentionstaff 2013-07-12 06:25:34 CEST
(In reply to Dirk Wiesenthal from comment #5)
> > Where is the difference between HTML in ini files and HTML in README_* files?
> 
> There is none. But HTML clutters the ini file whereas HTML in the README_*
> files feels... less wrong. At least they seem to be made for markup.

Why is it wrong? I think it is OK, if the ISV can write a word bold or can add a liisting.
Comment 7 Dirk Wiesenthal univentionstaff 2013-07-12 12:43:22 CEST
(In reply to Stefan Gohmann from comment #6)
> Why is it wrong?

It is not really wrong. But I do not like rendering unescaped HTML from an external source directly into UMC.

The alternative is putting a rather exhaustive text with listings and everything in README that is going to be rendered in the Installed Apps module. When allowing HTML in only one place I feel slightly better.

Anyway...

(In reply to Stefan Gohmann from comment #6)
> I think it is OK, if the ISV can write a word bold or can
> add a liisting.

Do we support HTML everywhere, e.g.
  Maintainer=Software GmbH &amp; Co KG
or just in (Long)Description (leading to inconsistencies)?

Note that we would have to force HTML, see example above, as we cannot decide whether the output was meant to go escaped or unescaped. We would require all Vendors to deliver HTML ini files.
Comment 8 Dirk Wiesenthal univentionstaff 2013-07-18 13:54:35 CEST
Allow (and enforce) HTML (only) in LongDescription in:
  univention-management-console-module-appcenter 3.0.8-1.152.201307181348
Comment 9 Alexander Kläser univentionstaff 2013-08-07 18:05:11 CEST
Changes → OK, only the LongDescription is displayed as HTML
Changelog → FAIL, no entry

→ REOPENED
Comment 10 Dirk Wiesenthal univentionstaff 2013-08-08 12:50:32 CEST
(In reply to Alexander Kläser from comment #9)
> Changelog → FAIL, no entry
> 
> → REOPENED

?? vim changelog-3.2.xml +644
Comment 11 Alexander Kläser univentionstaff 2013-08-12 16:31:33 CEST
(In reply to Dirk Wiesenthal from comment #10)
> (In reply to Alexander Kläser from comment #9)
> > Changelog → FAIL, no entry
> > 
> > → REOPENED
> 
> ?? vim changelog-3.2.xml +644

Now it is there, yes :) → VERIFIED
Comment 12 Stefan Gohmann univentionstaff 2013-11-19 06:44:31 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".