Univention Bugzilla – Bug 31652
Adoption of udm-users tests from ucs-3.0
Last modified: 2013-11-19 06:44:08 CET
The udm-users tests should be adopted from ucs-3.0.
Tests have been adopted.
As far as I understand the header has to be started as the second line: tests/61_udm-users/35_create_user_with_umlaut_in_uid #!/usr/share/ucs-test/runner python # -*- coding: utf-8 -*- ## desc: Create user with umlaut in username ## tags: [udm-users] ## roles: [domaincontroller_master] The test is started on non DC Master roles, see http://jenkins.knut.univention.de:8080/job/autotest/4/testReport/ Is the coding line required? If so, we should change the framework, otherwise the line should be removed.
(In reply to Stefan Gohmann from comment #2) > As far as I understand the header has to be started as the second line: > > tests/61_udm-users/35_create_user_with_umlaut_in_uid > #!/usr/share/ucs-test/runner python > # -*- coding: utf-8 -*- > ## desc: Create user with umlaut in username That happened for an other test, too: As a workaround move the encoding hint to the last line of the file. A better long term solution would be to teach ucs-test to ignore comment lines with only one hash symbol at the head of the file until the ucs-test header starts.
I have modified ucs-test to ignore lines beginning with a single hashtag in the test header.
As discussed, the univention-ox check should be removed.
(In reply to Stefan Gohmann from comment #5) > As discussed, the univention-ox check should be removed. Done.
Some minor issues: 01_user_creation_samba_option: utils.verify_ldap_object(udm.create_user(primaryGroup = 'cn=Domain Admins,cn=groups,%s' % ucr['ldap/base'], options = ['samba'])[0]) Please use separate calls, for example: user = udm.create_user(primaryGroup = 'cn=Domain Admins,cn=groups,%s' % ucr['ldap/base'], options = ['samba']) utils.verify_ldap_object(user[0]) The same in this test cases: 03_user_creation_samba_kerberos_options 04_user_creation_kerberos_posix_options 05_user_creation_kerberos_person_options 06_user_creation_person_option 06_user_creation_posix_option 07_user_creation_without_samba_option 08_user_creation_without_mail_option 09_user_creation_without_kerberos_option 10_user_creation_without_person_option 19_user_creation_with_umlaut_in_username 20_user_creation_person_mail_options 11_user_creation_without_posix_option: the test does not check if the object was created. 12_user_creation_with_username_already_in_use: the test case should use a different container. 14_user_creation_with_uid_already_in_use: please use in the test description and as variable name uidNumber because uid is by default a different attribute at least in ldap. 18_user_creation_set_jpegPhoto: please use a real jpeg example
The mentioned points have been implemented.
Some more minor issues: * 12_user_creation_with_username_already_in_use + 23_user_creation_with_username_already_in_use_apptest: we should not add such specific apptest tests here. I think these tests are obsolete since we changed the app default behavior: Bug #32212 * 00_user_creation: the user deletion should be checked as well
(In reply to Stefan Gohmann from comment #9) > Some more minor issues: > > * 12_user_creation_with_username_already_in_use + > 23_user_creation_with_username_already_in_use_apptest: we should not add > such specific apptest tests here. I think these tests are obsolete since we > changed the app default behavior: Bug #32212 The apptest version tests have been removed, in return I have added the "apptest" tag to the related udm-users tests again. > * 00_user_creation: the user deletion should be checked as well I've added a test for that.
(In reply to Lukas Walter from comment #10) > (In reply to Stefan Gohmann from comment #9) > > > Some more minor issues: > > > > * 12_user_creation_with_username_already_in_use + > > 23_user_creation_with_username_already_in_use_apptest: we should not add > > such specific apptest tests here. I think these tests are obsolete since we > > changed the app default behavior: Bug #32212 > > The apptest version tests have been removed, in return I have added the > "apptest" tag to the related udm-users tests again. OK > > * 00_user_creation: the user deletion should be checked as well > > I've added a test for that. OK
UCS 3.2 has been released: http://docs.univention.de/release-notes-3.2-en.html http://docs.univention.de/release-notes-3.2-de.html If this error occurs again, please use "Clone This Bug".