Bug 31921 - Duplicate UCR variable samba/max[/_]protocol
Duplicate UCR variable samba/max[/_]protocol
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba
UCS 3.1
All Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Arvid Requate
Stefan Gohmann
: interim-1
: 31143 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-09 09:43 CEST by Philipp Hahn
Modified: 2013-11-19 06:42 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-07-09 09:43:17 CEST
There are two similar UCR variables:
  samba/max/protocol
  samba/max_protocol
The both get exported to samba_max_protocol by "ucr shell", which results in errors in ucs-test/updater.

$ cd ~/GIT/branches/ucs-3.2/ucs-3.2-0/services
$ git grep -n samba.max.protocol
univention-samba/conffiles/etc/samba/smb.conf.d/01univention-samba_main:22:                    ('samba/max_protocol', 'max protocol'),
univention-samba/conffiles/etc/samba/smb.conf.d/61univention-samba_misc:20:if configRegistry.get('samba/max/protocol'):
univention-samba/conffiles/etc/samba/smb.conf.d/61univention-samba_misc:21:     print '\tmax protocol = %s' % configRegistry.get('samba/max/protocol')
univention-samba/debian/changelog:272:  * New UCR variable samba/max_protocol
univention-samba/debian/univention-samba.univention-config-registry:27:Variables: samba/max_protocol
univention-samba/debian/univention-samba.univention-config-registry-variables:367:[samba/max/protocol]
univention-samba/debian/univention-samba.univention-config-registry-variables:433:[samba/max_protocol]
univention-samba4/samba3upgrade/smb.conf.d/61univention-samba_misc:20:if configRegistry.get('samba/max/protocol'):
univention-samba4/samba3upgrade/smb.conf.d/61univention-samba_misc:21:  print '\tmax protocol = %s' % configRegistry.get('samba/max/protocol')

One of them should be deprecated and removed.
Comment 1 Stefan Gohmann univentionstaff 2013-07-09 09:54:52 CEST
See also Bug #31143.
Comment 2 Arvid Requate univentionstaff 2013-07-09 11:15:51 CEST
Just checked, samba/max/protocol is the one that works. The other one does not get translated into smb.conf.
Comment 3 Arvid Requate univentionstaff 2013-07-15 20:01:14 CEST
*** Bug 31143 has been marked as a duplicate of this bug. ***
Comment 4 Arvid Requate univentionstaff 2013-07-15 20:23:31 CEST
Fixed.
Comment 5 Stefan Gohmann univentionstaff 2013-08-14 13:46:38 CEST
Code / Test: OK

Changelog: OK
Comment 6 Stefan Gohmann univentionstaff 2013-11-19 06:42:16 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".