Bug 31985 - App Center now allows HTML in various places. Conversion needed
App Center now allows HTML in various places. Conversion needed
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UNSTABLE
Other Linux
: P5 enhancement (vote)
: UCS 3.2
Assigned To: Dirk Wiesenthal
Felix Botner
: interim-3
Depends on: 31185 31803
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-16 13:01 CEST by Dirk Wiesenthal
Modified: 2013-11-19 06:43 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2013-07-16 13:01:02 CEST
README_UPDATE and LICENSE_AGREEMENT now support (and enforce) HTML. One should look into those copied from UCS 3.1 and convert them if necessary. Links should contain a target="_blank".

+++ This bug was initially created as a clone of Bug #31803 +++

It should be possible to show an info message (popup) after the installation of an app. Also after the upgrade.

In the style of README_UPDATE. The files should show the content as HTML.

To make it consistent we should allow / support:
 - README_UPDATE
 - REAME_POST_UPDATE
 - README_INSTALLATION
 - REAME_POST_INSTALLATION

It should be documented in wiki or in the Developer Guide:
 http://wiki.univention.de/index.php?title=App_Center_-_.ini_file
 http://docs.univention.de/developer-reference-3.1.html
Comment 1 Dirk Wiesenthal univentionstaff 2013-07-18 13:58:13 CEST
Also check the LongDescription of the ini files. Characters like "&", "<", ">" now have to be escaped because HTML is allowed there due to Bug#31185.
Comment 2 Stefan Gohmann univentionstaff 2013-09-27 15:24:34 CEST
No changes needed for the current ini files.

@Nico, maybe you would like to inform the ISVs about the possibility to add HTML code.
Comment 3 Nico Gulden univentionstaff 2013-10-09 12:46:44 CEST
(In reply to Stefan Gohmann from comment #2)
> No changes needed for the current ini files.
> 
> @Nico, maybe you would like to inform the ISVs about the possibility to add
> HTML code.

The ISVs have been informed via mailing.
Comment 4 Felix Botner univentionstaff 2013-10-23 16:25:17 CEST
* OK - html in ini file (LongDescription)
* OK - html in LICENSE_AGREEMENT
* OK - html in README_UPDATE
* OK - 3.2 ini files
Comment 5 Dirk Wiesenthal univentionstaff 2013-11-15 10:54:34 CET
This cannot be WORKSFORME: Old files were simple text files that were HTMLified by applying a simple formatting function.

Now the files are put into the App Details as is, no more auto formatting.

This means that each and every old README* and LICENSE_AGREEMENT need to be converted:
"""
Update to version $SOME_VERSION

See https://somedomain/docu for more details.
"""
->
"""
<p>Update to version $SOME_VERSION</p>
<p>See <a href="https://somedomain/docu" target="_blank">https://somedomain/docu</a> for more details.</p>
"""

LICENSE_AGREEMENT that used to be bilingual ("=== ENGLISH === see below for German [...]") could now be split into two files LICENSE_AGREEMENT_DE and LICENSE_AGREEMENT (+ html)
Comment 6 Dirk Wiesenthal univentionstaff 2013-11-18 12:54:24 CET
Converted in appcenter.test. Not copied to real App Center yet to give QA the possiblity to compare
Comment 7 Felix Botner univentionstaff 2013-11-18 13:42:57 CET
all "links" converted to html links

please copy file to the appcenter
Comment 8 Dirk Wiesenthal univentionstaff 2013-11-18 14:09:04 CET
(In reply to Felix Botner from comment #7)
> please copy file to the appcenter

Done
Comment 9 Felix Botner univentionstaff 2013-11-18 17:04:41 CET
OK
Comment 10 Stefan Gohmann univentionstaff 2013-11-19 06:43:37 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".