Bug 32024 - join fails because of wrong ping to master
join fails because of wrong ping to master
Status: CLOSED WORKSFORME
Product: Z_Univention Corporate Client (UCC)
Classification: Unclassified
Component: General
unspecified
Other Linux
: P5 normal
: UCC 2.0
Assigned To: Felix Botner
Moritz Muehlenhoff
: interim-1
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-19 15:38 CEST by Florian Best
Modified: 2014-06-12 09:20 CEST (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2013-07-19 15:38:15 CEST
Check DC Master: + ping -c 1 master.ucs.school
+ ping6 -c 1 master.ucs.school
+ failed_message 'ping to master.ucs.school failed'
+ echo '* Join failed!

The join succeeds with the following change:
-if ! ping -c 1 "$DCNAME" >/dev/null 2>&1 && ! ping6 -c 1 "$DCNAME" >/dev/null 2>&1; then
+if (! ping -c 1 "$DCNAME" >/dev/null 2>&1) && (! ping6 -c 1 "$DCNAME" >/dev/null 2>&1); then
Comment 1 Moritz Muehlenhoff univentionstaff 2013-12-17 11:22:54 CET
Simple fix
Comment 2 Felix Botner univentionstaff 2014-04-04 16:08:22 CEST
I can see no reason for the parenthesis

-> more /tmp/test.sh 
if ! true >/dev/null 2>&1 && ! true >/dev/null 2>&1; then echo fail 1; fi
if ! true >/dev/null 2>&1 && ! false >/dev/null 2>&1; then echo fail 2; fi
if ! false >/dev/null 2>&1 && ! true >/dev/null 2>&1; then echo fail 3; fi
if ! false >/dev/null 2>&1 && ! false >/dev/null 2>&1; then echo fail 4; fi
if (! true >/dev/null 2>&1) && (! true >/dev/null 2>&1); then echo fail 5; fi
if (! true >/dev/null 2>&1) && (! false >/dev/null 2>&1); then echo fail 6; fi
if (! false >/dev/null 2>&1) && (! true >/dev/null 2>&1); then echo fail 7; fi
if (! false >/dev/null 2>&1) && (! false >/dev/null 2>&1); then echo fail 8; fi

-> sh /tmp/test.sh
fail 4
fail 8
-> bash /tmp/test.sh
fail 4
fail 8

(In reply to Florian Best from comment #0)
> Check DC Master: 
> + ping -c 1 master.ucs.school
> + ping6 -c 1 master.ucs.school
> + failed_message 'ping to master.ucs.school failed'
> + echo '* Join failed!

I guess both ping commands failed (because master.ucs.school was not reachable?) ...
Comment 3 Moritz Muehlenhoff univentionstaff 2014-04-09 10:04:36 CEST
Ok
Comment 4 Moritz Muehlenhoff univentionstaff 2014-06-12 09:20:06 CEST
UCC 2.0 has been released:
 http://docs.univention.de/release-notes-ucc-2.0.html

If this error occurs again, please use "Clone This Bug".