Bug 32882 - Improve Share module layout / texts
Improve Share module layout / texts
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Shares
UCS 3.1
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Erik Damrose
Felix Botner
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-16 13:38 CEST by Erik Damrose
Modified: 2013-11-19 06:42 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Damrose univentionstaff 2013-10-16 13:38:51 CEST
While working on Bug #21556 and #18708 improvements will be made to the umc-share module's layout and texts, based on internal discussions.
Comment 1 Erik Damrose univentionstaff 2013-10-16 14:07:37 CEST
Text and layout has been improved in

r45167 univention-directory-manager-modules 9.0.62-2.1128.201310161404
Comment 2 Moritz Muehlenhoff univentionstaff 2013-10-21 15:10:27 CEST
Uid bei Root-Zugriff umlenken / Redirect root access uid :

We should mention "root squashing" here. Proposed version:

DE: "User-ID für Root-Benutzer ändern (Root-Squashing)"
EN: "Modify user ID for root user (root squashing)"
Comment 3 Moritz Muehlenhoff univentionstaff 2013-10-21 15:19:16 CEST
Benutzergruppe für das Wurzelverzeichnis der Freigabe. Vorgabe ist root

Better

Besitzergruppe für das Wurzelverzeichnis der Freigabe.

(The "Vorgabe ist root" is redundant, since it's visible in the select box anyway)

(The English version is already correct)
Comment 4 Moritz Muehlenhoff univentionstaff 2013-10-21 15:23:50 CEST
Erlaubte Hosts, IP-Adressen oder Netze
-> Zugriff nur für diese Rechner, IP-Adressen oder Netze erlauben

Allowed hosts, ip addresses or networks
-> Only allow access for these hosts, IP addresses or networks

This makes it more explicit that the default is "allow all"
Comment 5 Moritz Muehlenhoff univentionstaff 2013-10-21 15:26:12 CEST
Anonymen Zugriff mit Gastbenutzer erlauben
Allow anonymous access with a guest user

->

Anonymen Nur-Lese-Zugriff mit Gastbenutzer erlauben
Allow anonymous read-only access with a guest user

This makes is more clear that it's limited to read-only accesses.
Comment 6 Moritz Muehlenhoff univentionstaff 2013-10-21 15:28:06 CEST
For the "MS-DFS root" option a link to the manual would be useful (e.g. in a tooltip or as part of the menu):
http://docs.univention.de/manual-3.2.html#shares::msdfs
Comment 7 Moritz Muehlenhoff univentionstaff 2013-10-21 15:36:22 CEST
"Users with write access" should rather be on the "Samba permissions" tab than the "Samba options" tab
Comment 8 Moritz Muehlenhoff univentionstaff 2013-10-22 09:04:14 CEST
(This is a long-standing bug that I noticed when updating the docs, it can also be split off):

In the UMC "Strict Locking" is currently a boolean option, while according according to the manpage it's actually an enumerated type, i.e. the actual Samba default ("auto") cannot be configured in the UMC.
Comment 9 Moritz Muehlenhoff univentionstaff 2013-10-22 09:11:11 CEST
Block Größe -> Blockgröße


Zugelassene Rechner -> Zugelassene Rechner/Netze (likewise for English and for "Nicht zugelasse Rechner")

(The option allows the configuration of hosts and networks, configuring a long list of hostnames is impractical anyway)
Comment 10 Moritz Muehlenhoff univentionstaff 2013-10-22 09:15:12 CEST
Liste von Schreibberechtigten / Users with write access:
->
Schreibberechtigung auf diese Benutzer/Gruppen beschränken / Restrict write access to these users/groups

This makes it more explicit what the default is and it also mentions that the configuration can be made for users or groups
Comment 11 Moritz Muehlenhoff univentionstaff 2013-10-22 09:54:51 CEST
The option "Inherit ACLs" doesn't have any effect in UCS. Quoting from the manpage:

| Note that using the VFS modules acl_xattr or acl_tdb which store native Windows
| as meta-data will automatically turn this option on for any share for which
| they are loaded, as they require this option to emulate Windows ACLs correctly.

samba-shares.py automatically adds acl_xattr or acl_tdb to each share (depending on the UCR variable samba4/ntacl/backend), so this share setting is moot and can be removed.
Comment 12 Moritz Muehlenhoff univentionstaff 2013-10-22 09:59:16 CEST
Inherit owner -> Create files/directories with the owner of the parent directory

Inherit permisions -> Create files/directories with permissions of the parent directory

(Likewise for German)
Comment 13 Erik Damrose univentionstaff 2013-10-23 11:57:30 CEST
Text/layout changes have been incorporated.
'strict locking' is no longer a checkbox but a select widget with the options auto, yes, no. The new default value is the smb.conf default: auto

r45501 univention-directory-manager-modules 9.0.69-3.1138.201310231149
changelog updated with 'strict locking' information
Comment 14 Felix Botner univentionstaff 2013-10-23 14:24:15 CEST
* please remove the Group( _( )) definition in the layout for 
  advanced Tabs (advanced), otherwise the options are under e.g.
  [Advanced settings] -> [Samba Permissions] -> [Samba Permissions]

  'Samba permissions'
  'Samba extended permissions'
  'Samba options'
  'Samba custom settings'
  'NFS custom settings'

(In reply to Moritz Muehlenhoff from comment #11)
> The option "Inherit ACLs" doesn't have any effect in UCS. Quoting from the
> manpage:
> 
> | Note that using the VFS modules acl_xattr or acl_tdb which store native
> Windows
> | as meta-data will automatically turn this option on for any share for which
> | they are loaded, as they require this option to emulate Windows ACLs
> correctly.
> 
> samba-shares.py automatically adds acl_xattr or acl_tdb to each share
> (depending on the UCR variable samba4/ntacl/backend), so this share setting
> is moot and can be removed.

* i can still see the "Inherit ACLs" option

* why are the options "Allowed hosts/networks" and "Denied hosts/networks"
  in "Samba Options" and not in "Samba permissions"

* change "Besitzer des freigegebenen Verzeichnisses" to 
  "Besitzer des Wurzelverzeichnis der Freigabe"

* please remove the "." at the end of
  "Benutzergruppe für das Wurzelverzeichnis der Freigabe."
Comment 15 Moritz Muehlenhoff univentionstaff 2013-10-23 16:03:11 CEST
(In reply to Felix Botner from comment #14)
> * please remove the "." at the end of
>   "Benutzergruppe für das Wurzelverzeichnis der Freigabe."

And it should read Besitzergruppe instead of Benutzergruppe



One additional issue:

In "Samba custom settings" there's an input field named "Schlüssel/Key". This is rather technical and should rather be labelled:

"Optionsname aus smb.conf / Option name in smb.conf"

Other than the issues mentioned by Felix it looks good to me in English and German.
Comment 16 Erik Damrose univentionstaff 2013-10-24 11:04:08 CEST
Layout and texts have been improved according to the suggestions.

> In "Samba custom settings" there's an input field named "Schlüssel/Key".
> This is rather technical and should rather be labelled:

This is a generic widget, the "Key/Value" texts can only be changed by developing individual widgets. I opted to change the text before the widget to
> "Optionsname aus smb.conf / Option name in smb.conf"
and improved the tool tip. I think this is enough.

univention-directory-manager-modules 9.0.71-1.1140.201310241059
no changelog update necessary.
Comment 17 Felix Botner univentionstaff 2013-10-25 09:57:42 CEST
OK 

OK - Changelog
Comment 18 Stefan Gohmann univentionstaff 2013-11-19 06:42:04 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".