Bug 33752 - rename_class does not rename sambaName of class share
rename_class does not rename sambaName of class share
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Import scripts
UCS@school 3.2
Other Linux
: P5 normal (vote)
: UCS@school 3.2 Errata
Assigned To: Janek Walkenhorst
Sönke Schwardt-Krummrich
:
Depends on:
Blocks: 34057
  Show dependency treegraph
 
Reported: 2013-12-13 16:47 CET by Sönke Schwardt-Krummrich
Modified: 2014-02-07 13:51 CET (History)
1 user (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2013-12-13 16:47:19 CET
The import script rename_class renames the class share objects itself but not the name of the samba share (if defined). If defined, the rename_class seems to have no effect → the files still appear in samba share with old name.

I think the rename_class script should also rename the samba name of the share if the samba name is equal to the share object name (mostly default).

If this is not the case, the customer has to fix it (semi-)manually, e.g. via a group-post-modify hook, that also alters the corresponding share object.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2013-12-13 16:48:41 CET
The sambaName/univentionShareSambaName is now set by default which leads to a broken rename_class functionality.
Comment 2 Janek Walkenhorst univentionstaff 2014-02-04 17:07:31 CET
ucs-school-import (10.0.4-4) unstable; urgency=low

  * rename_class: change sambaName too (Bug #33752)

sambaName is now changed too, if the name is equal to the class name.
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2014-02-05 11:35:45 CET
The classes shares are created with
  object["sambaForceGroup"] = "+%s"%classNr
which is currently not changed by rename_class.
→ REOPEN
Comment 4 Janek Walkenhorst univentionstaff 2014-02-05 15:56:35 CET
(In reply to Sönke Schwardt-Krummrich from comment #3)
> The classes shares are created with
>   object["sambaForceGroup"] = "+%s"%classNr
> which is currently not changed by rename_class.
> → REOPEN
ucs-school-import (10.0.4-5) unstable; urgency=low
  * rename_class: change sambaName and sambaForceGroup too (Bug #33752)
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2014-02-06 13:03:38 CET
OK: code change
OK: functional check
ADDED: changelog entry
Comment 6 Sönke Schwardt-Krummrich univentionstaff 2014-02-07 13:51:31 CET
UCS@school 3.2v2 has been released:
http://docs.univention.de/release-notes-ucsschool-3.2v2-de.pdf

If this error occurs again, please use "Clone This Bug".