Bug 34632 - Not resetting SMB connections on switching back to defaults
Not resetting SMB connections on switching back to defaults
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 3.2 R2
Other Linux
: P5 normal (vote)
: UCS@school 3.2 R2 Errata
Assigned To: Florian Best
Sönke Schwardt-Krummrich
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-24 14:13 CEST by Janis Meybohm
Modified: 2014-08-27 17:01 CEST (History)
4 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janis Meybohm univentionstaff 2014-04-24 14:13:13 CEST
2014041721010984

If computerroom settings are switched back to defaults (e.g. from "Home directory only") via "Reset", the remaining SMB connections are not reset.

"def settings_set" jumps into the "if request.options['internetRule'] == 'none' and request.options['shareMode'] == 'all' and request.options['printMode'] == 'default':" case and directly calls "_finished()"

Because of this, clients with open connections can't reconnect their "other" shares.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2014-07-18 12:09:35 CEST
This also affects the atjobs.
Comment 2 Florian Best univentionstaff 2014-08-18 14:55:15 CEST
Open SMB connections are now killed when switching back to default settings.

Afaics the atjobs have nothing to do with it as they are removed in every settings_set() call independent on which settings. No atjob is created for default settings as they are default and have no end time. → (leaving the bug currently opened).

Changelog has been created.
Comment 3 Nicolas Christener 2014-08-18 15:01:13 CEST
Hi :)

just a short remark from my side: a workaround which is quite useful in this case is: restrict printer access and give printer access free again - this somehow also unlocks the locked shares.

kind regards,
Nicolas
Comment 4 Florian Best univentionstaff 2014-08-19 10:51:09 CEST
When changing settings only 1 atjob was removed for the current room (fixed in svn52787, commit message contains wrong bug number Bug #35341). Now every atjob for the current selected room will be executed and removed when changing settings. There could be more than 1 atjob per room when using the same username in two sessions with the same room.
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2014-08-21 15:10:23 CEST
OK: changelog (added small changes)
OK: code change
OK: functionality (tested restart of SMB connections; tested removal of multiple at jobs per room)
Comment 6 Sönke Schwardt-Krummrich univentionstaff 2014-08-27 17:01:46 CEST
UCS@school 3.2 R2 v2 has been released:
http://docs.univention.de/release-notes-ucsschool-3.2R2v2-de.html

If this error occurs again, please use "Clone This Bug".