Bug 34923 - When password is set via CSV import the password history/complexity check should be ignored
When password is set via CSV import the password history/complexity check sho...
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - CSV Import
UCS@school 4.2
Other Linux
: P5 normal (vote)
: UCS@school 4.2 v2
Assigned To: Daniel Tröder
Florian Best
:
Depends on:
Blocks: 44266
  Show dependency treegraph
 
Reported: 2014-05-22 15:38 CEST by Sönke Schwardt-Krummrich
Modified: 2017-06-23 13:32 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 4: A User would return the product
User Pain: 0.229
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2014-05-22 15:38:34 CEST
When a password is set via CSV import the password history/complexity check should be ignored, otherwise the user may not be modified and the message

Dennis1 konnte nicht verändert werden.

is shown to the user and a traceback shown in logfile:

20.05.14 17:34:10.659  MODULE      ( WARN    ) : Something went wrong. Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/univention/management/console/modules/schoolcsvimport/util.py", line 210, in commit
    self.modify(lo, validate=False)
  File "/usr/lib/pymodules/python2.6/ucsschool/lib/models/base.py", line 409, in modify
    success = self.modify_without_hooks(lo, validate, move_if_necessary)
  File "/usr/lib/pymodules/python2.6/ucsschool/lib/models/base.py", line 432, in modify_without_hooks
    self.do_modify(udm_obj, lo)
  File "/usr/lib/pymodules/python2.6/ucsschool/lib/models/user.py", line 203, in do_modify
    return super(User, self).do_modify(udm_obj, lo)
  File "/usr/lib/pymodules/python2.6/ucsschool/lib/models/base.py", line 458, in do_modify
    udm_obj.modify(ignore_license=1)
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/__init__.py", line 345, in modify
    return self._modify(modify_childs,ignore_license=ignore_license)
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/__init__.py", line 799, in _modify
    ml=self._ldap_modlist()
  File "/usr/lib/pymodules/python2.6/univention/admin/handlers/users/user.py", line 1996, in _ldap_modlist
    raise univention.admin.uexceptions.pwalreadyused
pwalreadyused
Comment 1 Daniel Tröder univentionstaff 2017-04-10 16:36:45 CEST
Still a problem im UCS@school 4.2 v1.


10.04.17 16:30:16.622  MODULE      ( PROCESS ) : Going to modify CSVStudent imhorpf9kl
10.04.17 16:30:16.635  MODULE      ( PROCESS ) : Modifying CSVStudent(name='imhorpf9kl', school='SchuleSingleEins', dn='uid=imhorpf9kl,cn=schueler,cn=users,ou=SchuleSingleEins,dc=uni,dc=dtr')
10.04.17 16:30:16.638  MODULE      ( WARN    ) : UDM object cn=schueler-schulesingleeins,cn=groups,ou=SchuleSingleEins,dc=uni,dc=dtr does not correspond to a class in UCS school lib!
10.04.17 16:30:16.639  MODULE      ( WARN    ) : UDM object cn=Domain Users schulesingleeins,cn=groups,ou=SchuleSingleEins,dc=uni,dc=dtr does not correspond to a class in UCS school lib!
10.04.17 16:30:16.659  MODULE      ( WARN    ) : Something went wrong. Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/schoolcsvimport/util.py", line 247, in commit
    self.modify(lo, validate=False, move_if_necessary=False)
  File "/usr/lib/pymodules/python2.7/ucsschool/lib/models/base.py", line 481, in modify
    success = self.modify_without_hooks(lo, validate, move_if_necessary)
  File "/usr/lib/pymodules/python2.7/ucsschool/lib/models/base.py", line 504, in modify_without_hooks
    self.do_modify(udm_obj, lo)
  File "/usr/lib/pymodules/python2.7/ucsschool/lib/models/user.py", line 297, in do_modify
    return super(User, self).do_modify(udm_obj, lo)
  File "/usr/lib/pymodules/python2.7/ucsschool/lib/models/base.py", line 530, in do_modify
    udm_obj.modify(ignore_license=1)
  File "/usr/lib/pymodules/python2.7/univention/admin/handlers/users/user.py", line 1532, in modify
    return super(object, self).modify(*args, **kwargs)
  File "/usr/lib/pymodules/python2.7/univention/admin/handlers/__init__.py", line 318, in modify
    return self._modify(modify_childs, ignore_license=ignore_license)
  File "/usr/lib/pymodules/python2.7/univention/admin/handlers/__init__.py", line 806, in _modify
    ml = self._ldap_modlist()
  File "/usr/lib/pymodules/python2.7/univention/admin/handlers/users/user.py", line 1989, in _ldap_modlist
    raise univention.admin.uexceptions.pwalreadyused
pwalreadyused
Comment 2 Daniel Tröder univentionstaff 2017-04-10 16:42:54 CEST
Actually this is a regression in UCS@school 4.2 v1, as it seems to work in UCS@school 4.1 R2 v10.
Comment 3 Daniel Tröder univentionstaff 2017-05-03 09:34:09 CEST
r79033: ignore password history/complexity check when modifying existing users
r79034: advisory

Package: ucs-school-umc-csv-import
Version: 4.0.7-2A~4.2.0.201705030929
Branch: ucs_4.2-0
Scope: ucs-school-4.2
Comment 4 Florian Best univentionstaff 2017-05-09 15:17:35 CEST
OK: I could reproduce the problem and it works now.
OK: YAML

Why doesn't this happen during the inital creation of a user?
Comment 5 Daniel Tröder univentionstaff 2017-05-09 16:00:21 CEST
pwalreadyused cannot happen when creating a new user :)
Comment 6 Florian Best univentionstaff 2017-05-09 16:06:55 CEST
(In reply to Daniel Tröder from comment #5)
> pwalreadyused cannot happen when creating a new user :)
but the complexity check may trigger.
Comment 7 Sönke Schwardt-Krummrich univentionstaff 2017-06-23 13:32:23 CEST
UCS@school 4.2 v2 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.2v2-de.html

If this error occurs again, please clone this bug.