Bug 36316 - Adjust UCR variables for UCS startsite entries
Adjust UCR variables for UCS startsite entries
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Apache
UCS 3.2
Other Linux
: P5 normal (vote)
: UCS 4.0
Assigned To: Drees Dormann
Alexander Kläser
: interim-3
Depends on: 36095
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-27 16:09 CET by Alexander Kläser
Modified: 2014-11-26 06:53 CET (History)
2 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Design
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2014-10-27 16:09:20 CET
With UCS 4.0, only entries for UMC and installed apps will have their own icon on the UCS startsite. Other entries will no longer show an icon image. The corresponding .postinst scripts need therefore to adjust for the case of a package installation as well as for the update case (i.e., remove existing UCR variables ucs/web/overview/entries/.*/icon).
Comment 1 Drees Dormann univentionstaff 2014-10-29 13:18:44 CET
ucr variables have been removed from affected packages
also an ucr uset command has been added in case of an update
Comment 2 Alexander Kläser univentionstaff 2014-10-29 14:12:47 CET
Some still exist:
> management/univention-management-console/debian/univention-management-console-doc.postinst
> ./management/univention-management-console-frontend/34univention-management-console-web-server.inst
Comment 3 Alexander Kläser univentionstaff 2014-10-29 14:13:36 CET
(In reply to Alexander Kläser from comment #2)
> Some still exist:
> > management/univention-management-console/debian/univention-management-console-doc.postinst
> > ./management/univention-management-console-frontend/34univention-management-console-web-server.inst

The last one is fine, the path just needs to be adjusted as the .png file is obsolete (use */scalable/*.svg instead).
Comment 4 Drees Dormann univentionstaff 2014-10-29 15:03:29 CET
both have been adapted accordingly
Comment 5 Alexander Kläser univentionstaff 2014-10-30 14:16:37 CET
I could still find some:

> root@master5:~/build/management/univention-management-console-frontend# ucr search ucs/web.*icon
> ucs/web/overview/entries/.*/icon: <empty>
> ucs/web/overview/entries/admin/invalid-certificate-list/icon: /icon/50x50/invalid-certificate-list.png
> ucs/web/overview/entries/admin/root-certificate/icon: /icon/50x50/root-certificate.png
> ucs/web/overview/entries/admin/umc-doc/icon: /icon/50x50/univention_dev_logo.png
> ucs/web/overview/entries/admin/umc/icon: /univention-management-console/js/dijit/themes/umc/icons/scalable/univention-management-console.svg

BTW, for variables that are set in join scripts, I would suggest to remove the variables in the package's postinst script (instead of in the join script itself).
Comment 6 Drees Dormann univentionstaff 2014-10-31 11:09:51 CET
ucr varibales are now removed through postinstall scrip

added missing entries
Comment 7 Alexander Kläser univentionstaff 2014-11-05 13:00:40 CET
The following check does not look right to me, DC backups also have a link entry to the master system:

> if [ "$server_role"  = "domaincontroller_master" ] || [ "$server_role" = "domaincontroller_backup" ]; then
>    /usr/lib/univention-install/08univention-apache.inst || true
>     ucr unset \
>         ucs/web/overview/entries/admin/root-certificate/icon \
>         ucs/web/overview/entries/admin/invalid-certificate-list/icon
> else
>     ucr unset \
>         ucs/web/overview/entries/admin/ldap-master/icon
> fi

Much simpler would be without the if conditions:

> ucr unset \
>     ucs/web/overview/entries/admin/root-certificate/icon \
>     ucs/web/overview/entries/admin/invalid-certificate-list/icon \
>     ucs/web/overview/entries/admin/ldap-master/icon

Otherwise this looks good.
Comment 8 Drees Dormann univentionstaff 2014-11-05 14:09:33 CET
adapted postinst to make the removal of icon related ucr entries role unspecific
(r55390)
Comment 9 Alexander Kläser univentionstaff 2014-11-05 16:37:29 CET
Looks good now.
Changelog not necessary.
VERIFIED
Comment 10 Stefan Gohmann univentionstaff 2014-11-26 06:53:47 CET
UCS 4.0-0 has been released:
 http://docs.univention.de/release-notes-4.0-0-en.html
 http://docs.univention.de/release-notes-4.0-0-de.html

If this error occurs again, please use "Clone This Bug".