Bug 43417 - Update PPD files / printer list in UCS 4.2
Update PPD files / printer list in UCS 4.2
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Printserver
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2
Assigned To: Felix Botner
Janek Walkenhorst
: interim-3
: 43840 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-25 11:49 CET by Florian Best
Modified: 2017-04-04 18:29 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2017-01-25 11:49:50 CET
We need to update the list of printers / PPD files in UCS 4.2:

No PPD file found for LDAP printers:
hp-laserjet_m1536dnf_mfp-hpijs-pcl3.ppd

No LDAP printer found for PPD files:
Fuji_Xerox-DocuPrint_CM305_df-PDF.ppd
hp-deskjet_2520_series-hpijs.ppd
hp-laserjet_pro_mfp_m125rnw-hpijs.ppd
hp-deskjet_4510_series-hpijs.ppd
hp-deskjet_1510_series-hpijs.ppd
hp-color_laserjet_pro_mfp_m176n-hpijs.ppd
hp-deskjet_2640_series-hpijs.ppd
hp-deskjet_6520_series-hpijs.ppd
hp-envy_4500_series-hpijs.ppd
hp-photosmart_6520_series-hpijs.ppd
hp-officejet_pro_8620-hpijs.ppd
hp-officejet_pro_8640-hpijs.ppd
hp-deskjet_2020_series-hpijs.ppd
hp-laserjet_professional_m1219nfs_mfp-hpijs.ppd
hp-officejet_pro_3620-hpijs.ppd
hp-color_inkjet_cp1700-hpijs.ppd
hp-officejet_pro_8660-hpijs.ppd
hp-envy_5530_series-hpijs.ppd
hp-officejet_7610_series-hpijs.ppd
hp-laserjet_professional_m1218nfs_mfp-hpijs.ppd
hp-officejet_pro_8610-hpijs.ppd
hp-officejet_150_mobile_l511-hpijs.ppd
hp-deskjet_3510_series-hpijs.ppd
hp-officejet_pro_3610-hpijs.ppd
hp-laserjet_pro_mfp_m126nw-hpijs.ppd
hp-deskjet_1010_series-hpijs.ppd
hp-laserjet_professional_m1218nfg_mfp-hpijs.ppd
hp-color_laserjet_pro_mfp_m177fw-hpijs.ppd
hp-laserjet_professional_m1219nfg_mfp-hpijs.ppd
hp-deskjet_3540_series-hpijs.ppd
hp-officejet_7110_series-hpijs.ppd
hp-photosmart_7520_series-hpijs.ppd
hp-laserjet_pro_mfp_m125a-hpijs.ppd
hp-laserjet_pro_mfp_m127fn-hpijs.ppd
hp-deskjet_4640_series-hpijs.ppd
hp-laserjet_pro_mfp_m127fp-hpijs.ppd
hp-laserjet_pro_mfp_m128fn-hpijs.ppd
hp-envy_120_series-hpijs.ppd
hp-laserjet_pro_mfp_m125nw-hpijs.ppd
hp-laserjet_pro_mfp_m126a-hpijs.ppd
hp-officejet_2620_series-hpijs.ppd
hp-laserjet_pro_mfp_m128fp-hpijs.ppd
hp-officejet_4630_series-hpijs.ppd
hp-laserjet_pro_mfp_m127fw-hpijs.ppd
hp-laserjet_pro_mfp_m128fw-hpijs.ppd
hp-officejet_pro_8630-hpijs.ppd
hp-deskjet_2540_series-hpijs.ppd

http://jenkins.knut.univention.de:8080/job/UCS-4.2/job/UCS-4.2-0/job/AutotestJoin/22/SambaVersion=s4,Systemrolle=master/testReport/64_udm-printers/41_check_ppd/test/
Comment 1 Felix Botner univentionstaff 2017-02-28 16:53:01 CET
We no longer remove the ldap ppd list, instead we have to update the 4.1 list to match the ppds available in 4.2 .

 * add all new ppds (> 1000)
 * mark ppds, no longer available, as deprecated 
   (luckily only ca. 30 ppds are no longer available)

A better solution for handling the ppds list for different UCS server with different version can be done later (Bug #43672)

univention-printserver:
 * Joinscript:
   - split settings/printermodel create into create and modify (add 
     printmodel's), this way we can add new models with deleting the
     whole object
   - updated ppd list to 4.2
   - old models (ppd no longer available in 4.2) are now marked as 
     deprecated (with /usr/lib/univention-printserver/
     univention-ppds/mark_models_as_deprecated.py because udm-cli can't 
     handle remove of values with complex syntax)
   - new version 11
 * mark_models_as_deprecated.py
   - new script to mark models as deprecated
 * univention-printserver/ppds.py
   - updated, to 4.2

ucs-test:
 * enabled ucs-test/tests/64_udm-printers/41_check_ppd
 * ignore deprecated ppd's


QA
 * new installation in 4.2
 * update slave 4.1 with univention-printserver to 4.2
Comment 2 Felix Botner univentionstaff 2017-03-02 14:28:12 CET
Florian
An  botner

+		obj = self.models.lookup(self.co, self.lo, 'name=%s' % options.name)

hier fehlt ldap.filter.filter_format('name=%s', [options.name])

warum ist hier 1 und nicht 2?

    +				start_tls=1)



hier fehlt pipes.quote(cn)
    +			print '/usr/lib/univention-printserver/univention-ppds/mark_models_as_deprecated.py "$@" --name "%s" \\' % cn


annst du eventuell noch folgendes einbauen, damit sichergestellt ist, dass auch printer existieren:
assert ldap_printer
assert printer_files
Comment 3 Felix Botner univentionstaff 2017-03-02 14:33:57 CET
(In reply to Felix Botner from comment #2)
> Florian
> An  botner
> 
> +		obj = self.models.lookup(self.co, self.lo, 'name=%s' % options.name)
> 
> hier fehlt ldap.filter.filter_format('name=%s', [options.name])

changed

> 
> warum ist hier 1 und nicht 2?
> 
>     +				start_tls=1)
> 

changed
 
> hier fehlt pipes.quote(cn)
>     +			print
> '/usr/lib/univention-printserver/univention-ppds/mark_models_as_deprecated.
> py "$@" --name "%s" \\' % cn

hopefully this (ppds.py) is soon deprecated and it is only for internal use (to update the join script printer models), if it is not super important, i don't want to touch it again


> annst du eventuell noch folgendes einbauen, damit sichergestellt ist, dass
> auch printer existieren:
> assert ldap_printer
> assert printer_files

yep, changed
Comment 4 Florian Best univentionstaff 2017-03-16 14:58:06 CET
*** Bug 43840 has been marked as a duplicate of this bug. ***
Comment 5 Janek Walkenhorst univentionstaff 2017-03-16 17:55:09 CET
(In reply to Felix Botner from comment #1)
> We no longer remove the ldap ppd list, instead we have to update the 4.1
> list to match the ppds available in 4.2 .
> 
>  * mark ppds, no longer available, as deprecated 
>    (luckily only ca. 30 ppds are no longer available)
OK
Comment 6 Janek Walkenhorst univentionstaff 2017-03-17 11:07:05 CET
When updating printers with a changed description are duplicated, e.g.:

printerModel: "foomatic-rip/Samsung-ML-2570-hpijs-pcl5e.ppd" "Samsung ML-2570 Foomatic/hpijs-pcl5e (recommended)"
printerModel: "foomatic-rip/Samsung-ML-2570-hpijs-pcl5e.ppd" "Samsung ML-2570 Foomatic/hpijs-pcl5e"

printerModel: "hplip/HP/hp-psc_1300_series-hpijs.ppd" "HP PSC 1300 Series hpijs, 3.12.6"
printerModel: "hplip/HP/hp-psc_1300_series-hpijs.ppd" "HP PSC 1300 Series hpijs, 3.14.6"
Comment 7 Felix Botner univentionstaff 2017-03-20 13:48:40 CET
(In reply to Janek Walkenhorst from comment #6)
> When updating printers with a changed description are duplicated, e.g.:
> 
> printerModel: "foomatic-rip/Samsung-ML-2570-hpijs-pcl5e.ppd" "Samsung
> ML-2570 Foomatic/hpijs-pcl5e (recommended)"
> printerModel: "foomatic-rip/Samsung-ML-2570-hpijs-pcl5e.ppd" "Samsung
> ML-2570 Foomatic/hpijs-pcl5e"
> 
> printerModel: "hplip/HP/hp-psc_1300_series-hpijs.ppd" "HP PSC 1300 Series
> hpijs, 3.12.6"
> printerModel: "hplip/HP/hp-psc_1300_series-hpijs.ppd" "HP PSC 1300 Series
> hpijs, 3.14.6"

Added check_duplicates() to mark_models_as_deprecated.py and modified join script to call mark_as_... with -c (for checking duplicates).

check_duplicates() looks for models with identical ppds. These item are "removed" and a new item with the ppd and the current description is added.
Comment 8 Janek Walkenhorst univentionstaff 2017-03-20 18:07:29 CET
(In reply to Felix Botner from comment #7)
> (In reply to Janek Walkenhorst from comment #6)
> > When updating printers with a changed description are duplicated, e.g.:
> > 
> > printerModel: "foomatic-rip/Samsung-ML-2570-hpijs-pcl5e.ppd" "Samsung
> > ML-2570 Foomatic/hpijs-pcl5e (recommended)"
> > printerModel: "foomatic-rip/Samsung-ML-2570-hpijs-pcl5e.ppd" "Samsung
> > ML-2570 Foomatic/hpijs-pcl5e"
> > 
> > printerModel: "hplip/HP/hp-psc_1300_series-hpijs.ppd" "HP PSC 1300 Series
> > hpijs, 3.12.6"
> > printerModel: "hplip/HP/hp-psc_1300_series-hpijs.ppd" "HP PSC 1300 Series
> > hpijs, 3.14.6"
> 
> Added check_duplicates() to mark_models_as_deprecated.py and modified join
> script to call mark_as_... with -c (for checking duplicates).
> 
> check_duplicates() looks for models with identical ppds. These item are
> "removed" and a new item with the ppd and the current description is added.

OK
Comment 9 Stefan Gohmann univentionstaff 2017-04-04 18:29:27 CEST
UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".