Description Philipp Hahn 2017-03-16 11:58:57 CET

Created attachment 8552 [details]
Cleanup some shell issues

array[${#array[@]}]=var → array+=(var)
ldapsearch|ldapsearch-wrapper → ldapsearch -o ldif-wrap=no
sed -n 's/prefix: \(.*\)/\1/p' → sed -n 's/^prefix: //p'

debian/univention-samba4.postinst contains lots of now deprecated code from << ucs-4.2 upgrades, which should be removed.

Do we really need profile directories for Win95 WinNT Win2k, WinXP ... in 2017?

space before tabulator
trailing white space

S:1717-2: 96univention-samba4.inst:51:12: Use `ldapsearch -o ldif-wrap=no`
S:1717-3: 96univention-samba4.inst:217:4: Use `array+=(val)`
S:1717-3: 96univention-samba4.inst:220:4: Use `array+=(val)`
S:1717-1: 96univention-samba4.inst:315:42: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:313:20: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:348:49: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:346:10: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:395:149: Use `sed -n "s/^prefix: //p"`
S:1717-1: 96univention-samba4.inst:419:151: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:464:20: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:477:47: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:475:27: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:524:171: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:524:41: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:550:176: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:649:25: Use `ldapsearch -o ldif-wrap=no`
S:1717-2: 96univention-samba4.inst:746:25: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:789:41: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:787:26: Use `ldapsearch -o ldif-wrap=no`
S:1717-2: 96univention-samba4.inst:805:14: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:869:47: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:867:21: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 96univention-samba4.inst:873:47: Use `sed -n "s/^prefix: //p"`
S:1717-2: 96univention-samba4.inst:871:24: Use `ldapsearch -o ldif-wrap=no`
S:1717-2: 96univention-samba4.inst:996:17: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: 98univention-samba4-dns.inst:77:209: Use `sed -n "s/^prefix: //p"`
S:1717-2: 98univention-samba4-dns.inst:77:26: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: univention-s4search:62:144: Use `sed -n "s/^prefix: //p"`
S:1717-2: debian/univention-samba4.postinst:236:25: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: scripts/check_essential_samba4_dns_records.sh:32:104: Use `sed -n "s/^prefix: //p"`
S:1717-1: scripts/check_essential_samba4_dns_records.sh:54:195: Use `sed -n "s/^prefix: //p"`
S:1717-2: scripts/check_essential_samba4_dns_records.sh:54:20: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: scripts/check_essential_samba4_dns_records.sh:58:79: Use `sed -n "s/^prefix: //p"`
S:1717-1: scripts/check_essential_samba4_dns_records.sh:63:84: Use `sed -n "s/^prefix: //p"`
S:1717-1: scripts/setup-s4.sh:87:153: Use `sed -n "s/^prefix: //p"`
S:1717-2: scripts/setup-s4.sh:87:26: Use `ldapsearch -o ldif-wrap=no`
S:1717-3: scripts/setup-s4.sh:113:4: Use `array+=(val)`
S:1717-3: scripts/setup-s4.sh:116:4: Use `array+=(val)`
S:1717-1: scripts/setup-s4.sh:126:127: Use `sed -n "s/^prefix: //p"`
S:1717-1: scripts/setup-s4.sh:145:146: Use `sed -n "s/^prefix: //p"`
S:1717-2: scripts/setup-s4.sh:145:22: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: scripts/setup-s4.sh:229:166: Use `sed -n "s/^prefix: //p"`
S:1717-2: scripts/setup-s4.sh:229:45: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: scripts/setup-s4.sh:241:127: Use `sed -n "s/^prefix: //p"`
S:1717-2: scripts/setup-s4.sh:241:26: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: scripts/setup-s4.sh:258:106: Use `sed -n "s/^prefix: //p"`
S:1717-2: scripts/setup-s4.sh:258:22: Use `ldapsearch -o ldif-wrap=no`
S:1717-2: scripts/setup-s4.sh:267:23: Use `ldapsearch -o ldif-wrap=no`
S:1717-1: scripts/setup-s4.sh:268:58: Use `sed -n "s/^prefix: //p"`
S:1717-1: scripts/setup-s4.sh:270:41: Use `sed -n "s/^prefix: //p"`
S:1717-1: scripts/create_spn_account.sh:163:42: Use `sed -n "s/^prefix: //p"`
S:1717-1: server_password_change.d/univention-samba4:36:145: Use `sed -n "s/^prefix: //p"`
S:1717-2: lib/base.sh:80:20: Use `ldapsearch -o ldif-wrap=no`
S:1717-2: lib/base.sh:94:28: Use `ldapsearch -o ldif-wrap=no`
S:1717-2: lib/base.sh:100:23: Use `ldapsearch -o ldif-wrap=no`