Bug 44023 – 20_appcenter/17_app_status

Bug 44023 - 20_appcenter/17_app_status


Summary:	20_appcenter/17_app_status

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center
Version:	UCS 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.2
Assigned To:	Felix Botner
QA Contact:	Dirk Wiesenthal

URL:
Keywords:	interim-4

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-03-22 11:39 CET by Felix Botner
Modified:	2017-04-04 18:29 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Felix Botner

2017-03-22 11:39:52 CET

17_app_status uses the deprecated AppManager. We have to switch to univention.appcenter.app_cache (at least for the 4.1 docker apps).

20_appcenter/appcentertest.py -

get_requested_apps()
-from univention.appcenter import AppManager
+from univention.appcenter.app_cache import Apps
- app = AppManager.find(line.strip())
+ app = Apps().find(line.strip())

Comment 1 Felix Botner

2017-03-22 15:55:49 CET

replaced AppManager with Apps in 20_appcenter and 21_appcenter_uninstall

Comment 2 Stefan Gohmann

2017-03-23 06:15:26 CET

Please have a look here:

http://jenkins.knut.univention.de:8080/job/UCS-4.2/job/UCS-4.2-0/job/AutotestJoin/SambaVersion=s3,Systemrolle=member/87/testReport/21_appcenter-uninstall/25_app_uninstall/test/

(2017-03-22 22:13:33.963273) Traceback (most recent call last):
(2017-03-22 22:13:33.963365)   File "25_app_uninstall", line 96, in <module>
(2017-03-22 22:13:33.963470)     for app in get_requested_apps():
(2017-03-22 22:13:33.963531)   File "/usr/share/ucs-test/21_appcenter-uninstall/appcenteruninstalltest.py", line 48, in get_requested_apps
(2017-03-22 22:13:33.963637)     utils.fail('Error reading %s: %s' % (APPCENTER_FILE, exc))
(2017-03-22 22:13:33.963922) NameError: global name 'exc' is not defined

Comment 3 Felix Botner

2017-03-23 10:08:34 CET

(In reply to Stefan Gohmann from comment #2)
> Please have a look here:
> 
> http://jenkins.knut.univention.de:8080/job/UCS-4.2/job/UCS-4.2-0/job/
> AutotestJoin/SambaVersion=s3,Systemrolle=member/87/testReport/21_appcenter-
> uninstall/25_app_uninstall/test/
> 
> (2017-03-22 22:13:33.963273) Traceback (most recent call last):
> (2017-03-22 22:13:33.963365)   File "25_app_uninstall", line 96, in <module>
> (2017-03-22 22:13:33.963470)     for app in get_requested_apps():
> (2017-03-22 22:13:33.963531)   File
> "/usr/share/ucs-test/21_appcenter-uninstall/appcenteruninstalltest.py", line
> 48, in get_requested_apps
> (2017-03-22 22:13:33.963637)     utils.fail('Error reading %s: %s' %
> (APPCENTER_FILE, exc))
> (2017-03-22 22:13:33.963922) NameError: global name 'exc' is not defined

ok, i reverted that change (do not fail if /var/cache/appcenter-uninstalled.txt is missing)

Comment 4 Dirk Wiesenthal

2017-04-03 10:24:05 CEST

OK, works in my tests

Comment 5 Stefan Gohmann

2017-04-04 18:29:59 CEST

UCS 4.2 has been released:
 https://docs.software-univention.de/release-notes-4.2-0-en.html
 https://docs.software-univention.de/release-notes-4.2-0-de.html

If this error occurs again, please use "Clone This Bug".