Univention Bugzilla – Bug 44699
Typos (external feedback)
Last modified: 2021-05-06 14:10:32 CEST
We received feedback for the following typos: ucsschool/ucs-school-umc-printermoderation/umc/python/printermoderation/fr.po ----------------------------------------------------------------------------- File %r could not be printed as it does not exists (anymore). => File %r could not be printed as it does not exist (anymore). ucsschool/ucs-school-umc-wizards/umc/python/schoolwizards/fr.po --------------------------------------------------------------- The %s %r does not exists or might have been removed in the meanwhile. -> The %s %r does not exist or might have been removed in the meantime.
I fixed those typos with commits e234b313c Bug #44699: removed typos in fr.po 88deac8cb Bug #44699: remove typos on branch troehmey/bug44699_remove_typos
QA: The correction is OK, but: The texts which can be found in the *.po-files are updated by our poupdate-tools in the toolshed. If this is done otherwise, your changes might be overwritten with the next change. Please change the text inside the __init__.py and run the command.
Applied suggestions from comment #2 with a7d778962 Bug #44699: fixup d37676224 Bug #44699: fixed typos, updated po files
QA → looks OK, but I need some info before closing this. I'm sorry this is taking so long. I just had a look at this and could reproduce the scenario like this - Tested by opening a class in the schoolclass umc modul - deleting the class in the common umc modul - saving the (already deleted) class in the school modul The SchoolClass u'DEMOSCHOOL-testi' does not exists or might have been removed in the meanwhile. After the fix The SchoolClass u'DEMOSCHOOL-testi' does not exist or might have been removed in the meantime. How did you test your changes in l.240ff?
You can simply use the test 40_schoolwizards_admin_workaround.py which expects the error messages which are affected by this bug (from ucs-school-umc-wizards). The test needed a minor patch, which specifies the expected output language: ee382531f Bug #44699: specifying output language in test In order to check if the german translation is working, just change the language in the create_umc_client function from language="en_US" to "de_DE"
Reopen Code → OK Tests pass → OK please squash your commits, rebase, merge & build
Merged to 4.4 with: 874b93fdb Bug #44699: added advisories bb222e34f Bug #44699: added changelog entries 7217e0771 Bug #44699: Merge branch 'troehmey/bug44699_remove_typos' into 4.4 f1186e1d1 Bug #44699: specifying output language in test a14c2c4c6 Bug #44699: remove typos Builds: Package: ucs-school-umc-printermoderation Version: 16.0.0-3A~4.4.0.202104182151 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Package: ucs-school-umc-wizards Version: 11.0.0-14A~4.4.0.202104182154 Branch: ucs_4.4-0 Scope: ucs-school-4.4 Package: ucs-test-ucsschool Version: 6.0.205A~4.4.0.202104182157 Branch: ucs_4.4-0 Scope: ucs-school-4.4
All OK → verify merge → OK changelogs → OK advisories → OK jenkins → is happy
The Debian package for ucs-school-umc-printermoderation has only been imported into the build system, but has not been built.
Package: ucs-school-umc-printermoderation Version: 16.0.0-4A~4.4.0.202104221447 Branch: ucs_4.4-0 Scope: ucs-school-4.4 → set to resolve, verify after jenkins
jenkins is happy -> set to verify
Errata updates for UCS@school 4.4 v9 have been released. https://docs.software-univention.de/changelog-ucsschool-4.4v9-de.html If this error occurs again, please clone this bug.