Bug 45478 - Cleanup ucsschool-s4-branch-site.py
Cleanup ucsschool-s4-branch-site.py
Status: NEW
Product: UCS@school
Classification: Unclassified
Component: Samba 4 - Slave PDC
unspecified
Other Linux
: P5 normal (vote)
: ---
Assigned To: Samba maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-10-04 08:50 CEST by Philipp Hahn
Modified: 2017-10-05 10:28 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments
Cleanup (4.91 KB, patch)
2017-10-04 08:50 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2017-10-04 08:50:55 CEST
Created attachment 9237 [details]
Cleanup

import uldap is not used.
move imports to top (pyflakes).
No need to declare read-only or access-only variables as global.
Use of deprecated "except" syntax.
Print captured exception.